[PATCH] D141478: [include-cleaner] Improve header spelling in the presence of links

2023-01-11 Thread Sam McCall via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd7bba07526a7: [include-cleaner] Improve header spelling in the presence of links (authored by sammccall). Repository: rG LLVM Github Monorepo CHA

[PATCH] D141478: [include-cleaner] Improve header spelling in the presence of links

2023-01-11 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. In D141478#4043134 , @hokein wrote: > Thanks for tracking it down. The solution looks good to me. Since this is a > fragile and subtle issue, is it possible to have a unittest for it? If it is > not too hard, it would be nice

[PATCH] D141478: [include-cleaner] Improve header spelling in the presence of links

2023-01-11 Thread Haojian Wu via Phabricator via cfe-commits
hokein added a comment. Thanks for tracking it down. The solution looks good to me. Since this is a fragile and subtle issue, is it possible to have a unittest for it? If it is not too hard, it would be nice to have a test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D141478: [include-cleaner] Improve header spelling in the presence of links

2023-01-11 Thread Sam McCall via Phabricator via cfe-commits
sammccall created this revision. sammccall added reviewers: kadircet, hokein. Herald added a project: All. sammccall requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. HeaderSearch uses FileEntry::getName() to determine the best sp