RE: [PATCH] D141437: [HIP] Use .hipi as preprocessor output extension

2023-01-11 Thread Liu, Yaxun (Sam) via cfe-commits
-commits@lists.llvm.org; 473750...@qq.com; tul...@redhat.com; yronglin...@gmail.com; Kumar N, Bhuvanendra ; 1135831...@qq.com; gandhi21...@gmail.com; tbae...@redhat.com; mlek...@skidmore.edu; blitzrak...@gmail.com; shen...@google.com Subject: [PATCH] D141437: [HIP] Use .hipi as preprocessor output

[PATCH] D141437: [HIP] Use .hipi as preprocessor output extension

2023-01-11 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. I think this breaks tests on Windows: http://45.33.8.238/win/73191/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141437/new/ https://reviews.llvm.

[PATCH] D141437: [HIP] Use .hipi as preprocessor output extension

2023-01-11 Thread Yaxun Liu via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. yaxunl marked an inline comment as done. Closed by commit rGe8f41fdb5c6f: [HIP] Use .hipi as preprocessor output extension (authored by yaxunl). Herald added a project:

[PATCH] D141437: [HIP] Use .hipi as preprocessor output extension

2023-01-11 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:105 + " cui - cuda-cpp-output\n" + " hipi - hip-cpp-outpu\n" + " d- dependency\n" ---

[PATCH] D141437: [HIP] Use .hipi as preprocessor output extension

2023-01-11 Thread Artem Belevich via Phabricator via cfe-commits
tra accepted this revision. tra added inline comments. This revision is now accepted and ready to land. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:105 + " cui - cuda-cpp-output\n" + " hipi - hip-cpp-outpu\n" +

[PATCH] D141437: [HIP] Use .hipi as preprocessor output extension

2023-01-10 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl created this revision. yaxunl added a reviewer: tra. Herald added a project: All. yaxunl requested review of this revision. Herald added a subscriber: MaskRay. so that clang can recognize it and handle it automatically without -x hip-cpp-output https://reviews.llvm.org/D141437 Files: