[PATCH] D141350: Fix runtime problem for base class member data used in target region.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfe29a1695a6c: This is to fix runtime problem for member data used in target region. (authored by jyu2). Changed prior to commit: https://reviews.l

[PATCH] D141350: Fix runtime problem for base class member data used in target region.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141350/new/ https://reviews.llvm.org/D141350 ___

[PATCH] D141350: Fix runtime problem for base class member data used in target region.

jyu2 added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:8490 +if (MD) + if (const CXXRecordDecl *RD = dyn_cast(MD->getParent())) +HasBaseClass = RD->getNumBases() > 0; ABataev wrote: > `const auto *RD = dyn_cast(MD->getParen

[PATCH] D141350: Fix runtime problem for base class member data used in target region.

jyu2 updated this revision to Diff 487845. jyu2 added a comment. Thanks Alexey for code review. This is to address his comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141350/new/ https://reviews.llvm.org/D141350 Files: clang/lib/CodeGen

[PATCH] D141350: Fix runtime problem for base class member data used in target region.

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:8490 +if (MD) + if (const CXXRecordDecl *RD = dyn_cast(MD->getParent())) +HasBaseClass = RD->getNumBases() > 0; `const auto *RD = dyn_cast(MD->getParent())`. Also, c

[PATCH] D141350: Fix runtime problem for base class member data used in target region.

jyu2 added a comment. In D141350#4038619 , @ye-luo wrote: > Does this patch work when there are more than one level of inheritance? For > example `class B: public A; class C: public B` Yes, that works. For that we emit this[:1] instead. I can add mor

[PATCH] D141350: Fix runtime problem for base class member data used in target region.

ye-luo added a comment. Does this patch work when there are more than one level of inheritance? For example `class B: public A; class C: public B` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141350/new/ https://reviews.llvm.org/D141350

[PATCH] D141350: Fix runtime problem for base class member data used in target region.

jyu2 created this revision. jyu2 added reviewers: ABataev, jdoerfert, mikerice. jyu2 added a project: OpenMP. Herald added a project: All. jyu2 requested review of this revision. Herald added subscribers: openmp-commits, cfe-commits, sstefan1. Herald added a project: clang. The problem is happened