[PATCH] D141307: Add -f[no-]loop-versioning option

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGefae695d52cc: Add -f[no-]loop-versioning option (authored by MatsPetersson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D141307: Add -f[no-]loop-versioning option

Leporacanthicus updated this revision to Diff 514525. Leporacanthicus added a comment. Rebase only Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141307/new/ https://reviews.llvm.org/D141307 Files: clang/include/clang/Driver/Options.td clang/li

[PATCH] D141307: Add -f[no-]loop-versioning option

Leporacanthicus updated this revision to Diff 514403. Leporacanthicus added a comment. Rebase only Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141307/new/ https://reviews.llvm.org/D141307 Files: clang/include/clang/Driver/Options.td clang/li

[PATCH] D141307: Add -f[no-]loop-versioning option

Leporacanthicus updated this revision to Diff 513672. Leporacanthicus added a comment. Remove unnecessary braces in if-statement. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141307/new/ https://reviews.llvm.org/D141307 Files: clang/include/cla

[PATCH] D141307: Add -f[no-]loop-versioning option

awarzynski accepted this revision. awarzynski added a comment. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141307/new/ https://reviews.llvm.org/D141307 ___ cfe-commits mailing list cfe-co

[PATCH] D141307: Add -f[no-]loop-versioning option

Leporacanthicus updated this revision to Diff 512929. Leporacanthicus marked 3 inline comments as done. Leporacanthicus added a comment. - Add new function to help clarify the purpose of the options being used. - Add descriptive comment to make function use clearer. - Update tests to make them a m

[PATCH] D141307: Add -f[no-]loop-versioning option

Leporacanthicus updated this revision to Diff 512532. Leporacanthicus added a comment. Rebase only. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141307/new/ https://reviews.llvm.org/D141307 Files: clang/include/clang/Driver/Options.td clang/l

[PATCH] D141307: Add -f[no-]loop-versioning option

awarzynski added a comment. Mats, thanks for working on this! Just a few minor suggestions from me. Comment at: clang/lib/Driver/ToolChains/Flang.cpp:55 +static bool shouldLoopVersion(const ArgList &Args) { + if (Arg *A = Args.getLastArg(options::OPT_Ofast, options::OPT_O, -

[PATCH] D141307: Add -f[no-]loop-versioning option

Leporacanthicus updated this revision to Diff 511416. Leporacanthicus added a comment. Rebase only Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141307/new/ https://reviews.llvm.org/D141307 Files: clang/include/clang/Driver/Options.td clang/li

[PATCH] D141307: Add -f[no-]loop-versioning option

Leporacanthicus updated this revision to Diff 510756. Leporacanthicus added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141307/new/ https://reviews.llvm.org/D141307 Files: clang/include/clang/Driver/Options.td clang/lib/Dr

[PATCH] D141307: Add -f[no-]loop-versioning option

Leporacanthicus updated this revision to Diff 506125. Leporacanthicus added a comment. Rebase and fix conflicts Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141307/new/ https://reviews.llvm.org/D141307 Files: clang/include/clang/Driver/Options.

[PATCH] D141307: Add -f[no-]loop-versioning option

tblah accepted this revision. tblah added a comment. This revision is now accepted and ready to land. Looks good to me Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141307/new/ https://reviews.llvm.org/D141307 _

[PATCH] D141307: Add -f[no-]loop-versioning option

Leporacanthicus updated this revision to Diff 503459. Leporacanthicus marked an inline comment as done. Leporacanthicus added a comment. Fix copied comment to reflect the new content. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141307/new/ https:

[PATCH] D141307: Add -f[no-]loop-versioning option

Leporacanthicus marked an inline comment as done. Leporacanthicus added inline comments. Comment at: clang/lib/Driver/ToolChains/Flang.cpp:69 + Arg *loopVersioning = + Args.getLastArg(options::OPT_Ofast, options::OPT_floop_versioning, + options::OPT_fno

[PATCH] D141307: Add -f[no-]loop-versioning option

Leporacanthicus updated this revision to Diff 503360. Leporacanthicus added a comment. Herald added a reviewer: sscalpone. Updates based on review comments: - Add tests. - Enable on -O3 Also changed the name to match gfortran. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D141307: Add -f[no-]loop-versioning option

tblah added a comment. Please could you add tests for the flag forwarding logic in flang/tests/Driver/frontend-forwarding.f90. For example see https://reviews.llvm.org/rGd0d4b635786d510cd919cadbeb7e5e19983242cf Comment at: clang/lib/Driver/ToolChains/Flang.cpp:69 + Arg *loop