This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG3432f4bf86e7: [test] Split out Annotations from
`TestingSupport` (authored by rupprecht).
Changed prior to commit:
https://reviews.llvm.org/D14117
sammccall accepted this revision.
sammccall added a comment.
This looks good, i think it also doesn't belong in Testing/Support because it's
not a peer to anything in Support/.
I think you can use `PARTIAL_SOURCES_INTENDED` to partition directories, but
it's unusual and a bit of a hassle. Eithe
rupprecht updated this revision to Diff 488381.
rupprecht added a comment.
- Remove redundant comment
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D141175/new/
https://reviews.llvm.org/D141175
Files:
clang-tools-extra/clangd/unittests/Annotation
GMNGeoffrey accepted this revision.
GMNGeoffrey added a comment.
This revision is now accepted and ready to land.
LGTM (+/- nits), but maybe good to get review from someone more closely
associated with the TestingSupport library
Comment at: utils/bazel/llvm-project-overlay/llv
