[PATCH] D141144: [clang-tidy][doc] Improve clang-tidy documentation

PiotrZSL added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/index.rst:272 + parent one. +SystemHeaders- Same as '--system-headers'. +UseColor - Same as '--use-color'.

[PATCH] D141144: [clang-tidy][doc] Improve clang-tidy documentation

This revision was automatically updated to reflect the committed changes. Closed by commit rG2706919f9197: [clang-tidy][doc] Improve clang-tidy documentation (authored by carlosgalvezp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141144/new/ http

[PATCH] D141144: [clang-tidy][doc] Improve clang-tidy documentation

carlosgalvezp marked an inline comment as done. carlosgalvezp added a comment. All comments have been addressed, I intend to land the patch by February 9th unless more feedback is received. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141144/new/

[PATCH] D141144: [clang-tidy][doc] Improve clang-tidy documentation

carlosgalvezp marked an inline comment as done. carlosgalvezp added inline comments. Comment at: clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp:34 +static StringRef TrimFirstChar(StringRef x) { return x.substr(1); } + ClockMan wrote: > Looks like usecase o

[PATCH] D141144: [clang-tidy][doc] Improve clang-tidy documentation

carlosgalvezp updated this revision to Diff 493110. carlosgalvezp added a comment. Wrap trimming functionality in desc function. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141144/new/ https://reviews.llvm.org/D141144 Files: clang-tools-extra/

[PATCH] D141144: [clang-tidy][doc] Improve clang-tidy documentation

ClockMan added inline comments. Comment at: clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp:34 +static StringRef TrimFirstChar(StringRef x) { return x.substr(1); } + Looks like usecase of this is more like rtrim, then probably rtrim should be used instead

[PATCH] D141144: [clang-tidy][doc] Improve clang-tidy documentation

carlosgalvezp added a comment. Friendly ping @njames93 , see my previous comment about `TrimFirstChar`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141144/new/ https://reviews.llvm.org/D141144 ___ cfe-

[PATCH] D141144: [clang-tidy][doc] Improve clang-tidy documentation

carlosgalvezp updated this revision to Diff 491731. carlosgalvezp edited the summary of this revision. carlosgalvezp added a comment. Remove newline Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141144/new/ https://reviews.llvm.org/D141144 Files:

[PATCH] D141144: [clang-tidy][doc] Improve clang-tidy documentation

carlosgalvezp updated this revision to Diff 491729. carlosgalvezp added a comment. Fix formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141144/new/ https://reviews.llvm.org/D141144 Files: clang-tools-extra/clang-tidy/tool/ClangTidyMain.c

[PATCH] D141144: [clang-tidy][doc] Improve clang-tidy documentation

carlosgalvezp updated this revision to Diff 491728. carlosgalvezp added a comment. Add HeaderFileExtensions and ImplementationFileExtensions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141144/new/ https://reviews.llvm.org/D141144 Files: clang-

[PATCH] D141144: [clang-tidy][doc] Improve clang-tidy documentation

carlosgalvezp updated this revision to Diff 42. carlosgalvezp added a comment. Add ExtraArgs and ExtraArgsBefore Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141144/new/ https://reviews.llvm.org/D141144 Files: clang-tools-extra/clang-tidy/t

[PATCH] D141144: [clang-tidy][doc] Improve clang-tidy documentation

carlosgalvezp added inline comments. Comment at: clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp:34 +static StringRef TrimFirstChar(StringRef x) { return x.substr(1); } + njames93 wrote: > This seems a bit of a needless change, if you want to remove the ne

[PATCH] D141144: [clang-tidy][doc] Improve clang-tidy documentation

carlosgalvezp updated this revision to Diff 487844. carlosgalvezp marked 3 inline comments as done. carlosgalvezp added a comment. Revert changes to CheckOptions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141144/new/ https://reviews.llvm.org/D14

[PATCH] D141144: [clang-tidy][doc] Improve clang-tidy documentation

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp:34 +static StringRef TrimFirstChar(StringRef x) { return x.substr(1); } + This seems a bit of a needless change, if you want to remove the newline, just in date th

[PATCH] D141144: [clang-tidy][doc] Improve clang-tidy documentation

carlosgalvezp added a comment. @njames93 Do you agree with the overall idea of documenting config file options like this? I need this in place for the other patch that cleans the duplication for `HeaderFileExtensions`, `ImplementationFileExtensions`, `IncludeStyle`, etc. Repository: rG LLVM

[PATCH] D141144: [clang-tidy][doc] Improve clang-tidy documentation

carlosgalvezp updated this revision to Diff 487370. carlosgalvezp added a comment. Trim first character instead, to keep the code visually pleasing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141144/new/ https://reviews.llvm.org/D141144 Files:

[PATCH] D141144: [clang-tidy][doc] Improve clang-tidy documentation

carlosgalvezp updated this revision to Diff 487363. carlosgalvezp marked an inline comment as done. carlosgalvezp added a comment. Fix formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141144/new/ https://reviews.llvm.org/D141144 Files: c

[PATCH] D141144: [clang-tidy][doc] Improve clang-tidy documentation

Eugene.Zelenko accepted this revision. Eugene.Zelenko added a comment. This revision is now accepted and ready to land. But will be good idea to wait for other reviewers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141144/new/ https://reviews.llv

[PATCH] D141144: [clang-tidy][doc] Improve clang-tidy documentation

carlosgalvezp marked 2 inline comments as done. carlosgalvezp added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/index.rst:142 e.g. --config-file=/some/path/myTidyConfigFile -This option

[PATCH] D141144: [clang-tidy][doc] Improve clang-tidy documentation

Eugene.Zelenko accepted this revision. Eugene.Zelenko added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/docs/clang-tidy/index.rst:142 e.g. --config-file=/some/path/myTidyConfigFile -

[PATCH] D141144: [clang-tidy][doc] Improve clang-tidy documentation

carlosgalvezp updated this revision to Diff 486922. carlosgalvezp added a comment. Fix alignment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141144/new/ https://reviews.llvm.org/D141144 Files: clang-tools-extra/clang-tidy/tool/ClangTidyMain.cp

[PATCH] D141144: [clang-tidy][doc] Improve clang-tidy documentation

carlosgalvezp updated this revision to Diff 486921. carlosgalvezp added a comment. Remove colon after the config options, for consistency with the command-line options. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141144/new/ https://reviews.llvm.

[PATCH] D141144: [clang-tidy][doc] Improve clang-tidy documentation

carlosgalvezp updated this revision to Diff 486916. carlosgalvezp added a comment. Fix incorrect dash in key/value pairs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141144/new/ https://reviews.llvm.org/D141144 Files: clang-tools-extra/clang-ti

[PATCH] D141144: [clang-tidy][doc] Improve clang-tidy documentation

carlosgalvezp updated this revision to Diff 486915. carlosgalvezp added a comment. Remove wrong dash in key/value options. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141144/new/ https://reviews.llvm.org/D141144 Files: clang-tools-extra/clang-

[PATCH] D141144: [clang-tidy][doc] Improve clang-tidy documentation

carlosgalvezp updated this revision to Diff 486913. carlosgalvezp added a comment. Remove extra newline Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141144/new/ https://reviews.llvm.org/D141144 Files: clang-tools-extra/clang-tidy/tool/ClangTidy

[PATCH] D141144: [clang-tidy][doc] Improve clang-tidy documentation

carlosgalvezp created this revision. Herald added subscribers: arphaman, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. carlosgalvezp requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. - Specify that the