[PATCH] D141098: [clang-format][NFC] Set LineEnding to LF in config files

owenpan added a comment. In D141098#4192785 , @mehdi_amini wrote: > In D141098#4111809 , @owenpan wrote: > >> Can we just fix the buildbot so that it runs git-clang-format with >> `--binary`? Using clang-format-

[PATCH] D141098: [clang-format][NFC] Set LineEnding to LF in config files

mehdi_amini added a comment. In D141098#4111809 , @owenpan wrote: > Can we just fix the buildbot so that it runs git-clang-format with > `--binary`? Using clang-format-15 to format a patch to clang-format-16 source > still looks wrong to me. The genera

[PATCH] D141098: [clang-format][NFC] Set LineEnding to LF in config files

owenpan added a comment. In D141098#4111890 , @sunho wrote: > I think it makes more sense to use stable version of clang-format for that > purpose but I'm not in a postion to decide as I don't work with format. Can > you change the script to use latest

[PATCH] D141098: [clang-format][NFC] Set LineEnding to LF in config files

sunho added a comment. I think it makes more sense to use stable version of clang-format for that purpose but I'm not in a postion to decide as I don't work with format. Can you change the script to use latest clang-format for format codebase and revert this patch in the meantime? Currently, al

[PATCH] D141098: [clang-format][NFC] Set LineEnding to LF in config files

owenpan added a comment. In D141098#4111830 , @sunho wrote: > Wouldn't that mean llvm contributors have to format their code using > clang-format built from top-of-tree source code before submitting the patch? Only if the patch is to clang-format source

[PATCH] D141098: [clang-format][NFC] Set LineEnding to LF in config files

sunho added a comment. Wouldn't that mean llvm contributors have to format their code using clang-format built from top-of-tree source code before submitting the patch? Technically that script is for checking if the code has been formatted correctly. Repository: rG LLVM Github Monorepo CHA

[PATCH] D141098: [clang-format][NFC] Set LineEnding to LF in config files

owenpan added a comment. In D141098#4108286 , @sunho wrote: > I think buildbot is "formatting" the patch using clang-format-15. The tests > of clang-format would be done with latest code. Can we just fix the buildbot so that it runs git-clang-format wit

[PATCH] D141098: [clang-format][NFC] Set LineEnding to LF in config files

sunho added a comment. I think buildbot is "formatting" the patch using clang-format-15. The tests of clang-format would be done with latest code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141098/new/ https://reviews.llvm.org/D141098

[PATCH] D141098: [clang-format][NFC] Set LineEnding to LF in config files

owenpan added a comment. Why don't we fix the buildbot instead? Why does it use a pre-16 version to test 16 source? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141098/new/ https://reviews.llvm.org/D141098 ___

[PATCH] D141098: [clang-format][NFC] Set LineEnding to LF in config files

MyDeveloperDay added a comment. I guess we'll need to revert this until the buildbots are updated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141098/new/ https://reviews.llvm.org/D141098 ___ cfe-commi

[PATCH] D141098: [clang-format][NFC] Set LineEnding to LF in config files

sunho added a comment. This seems to be causing builtbot lint script error: https://buildkite.com/llvm-project/premerge-checks/builds/134501#01862630-8fa9-487c-99b1-9addbe6257d0 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141098/new/ https://rev

[PATCH] D141098: [clang-format][NFC] Set LineEnding to LF in config files

This revision was automatically updated to reflect the committed changes. Closed by commit rGdadfc6b38b00: [clang-format][NFC] Set LineEnding to LF in config files (authored by owenpan). Changed prior to commit: https://reviews.llvm.org/D141098?vs=486708&id=491142#toc Repository: rG LLVM Git