[PATCH] D141092: Optionally install clang-tblgen to aid cross-compiling

2023-01-12 Thread Nikita Popov via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG706881825b24: [cmake] Optionally install clang-tblgen to aid cross-compiling (authored by chewi, committed by nikic). Repository: rG LLVM Github M

[PATCH] D141092: Optionally install clang-tblgen to aid cross-compiling

2023-01-11 Thread James Le Cuirot via Phabricator via cfe-commits
chewi added a comment. James Le Cuirot I'm new to this process, so thanks for bearing with me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141092/new/ https://reviews.llvm.org/D141092 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D141092: Optionally install clang-tblgen to aid cross-compiling

2023-01-11 Thread Nikita Popov via Phabricator via cfe-commits
nikic added a comment. Can you please share the `Name ` to use for the commit? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141092/new/ https://reviews.llvm.org/D141092 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D141092: Optionally install clang-tblgen to aid cross-compiling

2023-01-11 Thread James Le Cuirot via Phabricator via cfe-commits
chewi added a comment. I don't have commit access. Please merge this for me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141092/new/ https://reviews.llvm.org/D141092 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[PATCH] D141092: Optionally install clang-tblgen to aid cross-compiling

2023-01-11 Thread Nikita Popov via Phabricator via cfe-commits
nikic accepted this revision. nikic added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141092/new/ https://reviews.llvm.org/D141092 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D141092: Optionally install clang-tblgen to aid cross-compiling

2023-01-07 Thread James Le Cuirot via Phabricator via cfe-commits
chewi added a comment. I forgot to add: I notice you no longer need llvm-tblgen already present when cross-compiling LLVM, but sadly, that still isn't the case for clang-tblgen. I tried leveraging CrossCompile.cmake to perform a "NATIVE" Clang build, but I think a lot more work would be needed

[PATCH] D141092: Optionally install clang-tblgen to aid cross-compiling

2023-01-07 Thread James Le Cuirot via Phabricator via cfe-commits
chewi updated this revision to Diff 487073. chewi edited the summary of this revision. chewi added a reviewer: nikic. chewi added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Reworked and retested against the main branch. Thankfully, it is simpler now. CHANGE

[PATCH] D141092: Optionally install clang-tblgen to aid cross-compiling

2023-01-05 Thread James Le Cuirot via Phabricator via cfe-commits
chewi added a comment. Apologies. I conceived this against 15.0.6, but have now noticed that the latest TableGen.cmake may have changed things. I'll retest tomorrow and adjust as necessary. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141092/new/

[PATCH] D141092: Optionally install clang-tblgen to aid cross-compiling

2023-01-05 Thread James Le Cuirot via Phabricator via cfe-commits
chewi created this revision. chewi added a reviewer: MaskRay. chewi added a project: clang. Herald added a subscriber: StephenFan. Herald added a project: All. chewi requested review of this revision. Herald added a subscriber: cfe-commits. clang-tblgen is required to cross-compile clang itself. T