[PATCH] D140828: [WIP][C++] Implement "Deducing this" (P0847R7)

2023-01-03 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin added inline comments. Comment at: clang/lib/AST/MicrosoftMangle.cpp:2560 IsInLambda = true; -if (MD->isInstance()) +if (MD->isImplicitObjectMemberFunction()) HasThisQuals = true; erichkeane wrote: > cor3ntin wrote: > > erichkeane w

[PATCH] D140828: [WIP][C++] Implement "Deducing this" (P0847R7)

2023-01-03 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added inline comments. Comment at: clang/lib/AST/MicrosoftMangle.cpp:2560 IsInLambda = true; -if (MD->isInstance()) +if (MD->isImplicitObjectMemberFunction()) HasThisQuals = true; cor3ntin wrote: > erichkeane wrote: > > This bit p

[PATCH] D140828: [WIP][C++] Implement "Deducing this" (P0847R7)

2023-01-03 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin added inline comments. Comment at: clang/include/clang/AST/Expr.h:1447 + bool Set, const ASTContext &Context) { +DeclRefExprBits.CapturedByCopyInLambdaWithExplicitObjectParameter = Set; +setDependence(computeDependence(this, Context)); erich

[PATCH] D140828: [WIP][C++] Implement "Deducing this" (P0847R7)

2023-01-03 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added a comment. I did a look through, I'm quite sure I'm not going to be able to accept this, but I'm hoping the little feedback I gave helped. I can't help with the review of the mangling unfortunately, we probably need to wait for the owners of the manglings to make a decision.