[PATCH] D140809: [clang][Interp] Implement logical and/or operators

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd2ea8ae5d43e: [clang][Interp] Implement logical and/or operators (authored by tbaeder). Changed prior to commit: https://reviews.llvm.org/D140809?

[PATCH] D140809: [clang][Interp] Implement logical and/or operators

aaron.ballman accepted this revision. aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:376 +this->emitLabel(LabelTrue); +this->emitConstBool(true, E); +this->fallthrough(LabelEnd); tbaeder wrote: > aaron.ballma

[PATCH] D140809: [clang][Interp] Implement logical and/or operators

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:376 +this->emitLabel(LabelTrue); +this->emitConstBool(true, E); +this->fallthrough(LabelEnd); aaron.ballman wrote: > Am I correct in understanding that the reason we d

[PATCH] D140809: [clang][Interp] Implement logical and/or operators

aaron.ballman added a comment. Assuming my understanding is correct, this LGTM! Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:376 +this->emitLabel(LabelTrue); +this->emitConstBool(true, E); +this->fallthrough(LabelEnd); Am I correct in unders

[PATCH] D140809: [clang][Interp] Implement logical and/or operators

shafik added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:387 + // Logical AND. + // Visit LHS. Only visit RHS is LHS was TRUE. + LabelTy LabelFalse = this->getLabel(); Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D140809: [clang][Interp] Implement logical and/or operators

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://revi