[PATCH] D140807: [clang][Interp] Skip calling simple destructors

2023-01-05 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder abandoned this revision. tbaeder added a comment. I added the `isTrivial()` checks to the new version in https://reviews.llvm.org/D137070. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140807/new/ https://reviews.llvm.org/D140807

[PATCH] D140807: [clang][Interp] Skip calling simple destructors

2023-01-03 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder added a comment. What a shame. :( Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140807/new/ https://reviews.llvm.org/D140807 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[PATCH] D140807: [clang][Interp] Skip calling simple destructors

2023-01-03 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added a comment. This still would have to call the destructors of base and member types, right? And this just means that it isn't user defined AND isn't deleted for some reason, so this doesn't mean 'trivial'. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D140807: [clang][Interp] Skip calling simple destructors

2022-12-31 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Calling them isn't needed if I understand correctly