[PATCH] D140793: [clang-tidy] Implement CppCoreGuideline CP.53

This revision was automatically updated to reflect the committed changes. Closed by commit rGb06b248ad9dc: [clang-tidy] Implement CppCoreGuideline CP.53 (authored by ccotter, committed by carlosgalvezp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D140793: [clang-tidy] Implement CppCoreGuideline CP.53

ccotter marked 4 inline comments as done. ccotter added a comment. In D140793#4021694 , @carlosgalvezp wrote: > LGTM, thanks for the patch! Maybe wait a couple days before landing to give > some extra time for other reviewers. You might also want to mar

[PATCH] D140793: [clang-tidy] Implement CppCoreGuideline CP.53

carlosgalvezp accepted this revision. carlosgalvezp added a comment. This revision is now accepted and ready to land. LGTM, thanks for the patch! Maybe wait a couple days before landing to give some extra time for other reviewers. You might also want to mark the comments as "Done", so reviewers

[PATCH] D140793: [clang-tidy] Implement CppCoreGuideline CP.53

ccotter updated this revision to Diff 485827. ccotter added a comment. - oops - bad arc diff / bad change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140793/new/ https://reviews.llvm.org/D140793 Files: clang-tools-extra/clang-tidy/cppcoreguid

[PATCH] D140793: [clang-tidy] Implement CppCoreGuideline CP.53

ccotter updated this revision to Diff 485824. ccotter added a comment. - Cleanups Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140793/new/ https://reviews.llvm.org/D140793 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/AvoidReferenceCor

[PATCH] D140793: [clang-tidy] Implement CppCoreGuideline CP.53

carlosgalvezp added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/AvoidReferenceCoroutineParametersCheck.cpp:31 +const MatchFinder::MatchResult &Result) { + const auto *Param = Result.Nodes.getNodeAs("param"); + Check for nullp

[PATCH] D140793: [clang-tidy] Implement CppCoreGuideline CP.53

ccotter updated this revision to Diff 485783. ccotter added a comment. - Does not offer fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140793/new/ https://reviews.llvm.org/D140793 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/Avoid

[PATCH] D140793: [clang-tidy] Implement CppCoreGuideline CP.53

ccotter updated this revision to Diff 485782. ccotter added a comment. - run clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140793/new/ https://reviews.llvm.org/D140793 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/AvoidRefe

[PATCH] D140793: [clang-tidy] Implement CppCoreGuideline CP.53

ccotter updated this revision to Diff 485746. ccotter added a comment. spelling Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140793/new/ https://reviews.llvm.org/D140793 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/AvoidReferenceCorou

[PATCH] D140793: [clang-tidy] Implement CppCoreGuideline CP.53

ccotter updated this revision to Diff 485745. ccotter added a comment. move reference link Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140793/new/ https://reviews.llvm.org/D140793 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/AvoidRef

[PATCH] D140793: [clang-tidy] Implement CppCoreGuideline CP.53

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/cppcoreguidelines/avoid-reference-coroutine-parameters.rst:9 + +This check implements +[CppCoreGuideline CP.53](http://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines). -

[PATCH] D140793: [clang-tidy] Implement CppCoreGuideline CP.53

ccotter added a comment. Passing and accessing a reference is safe if the access is done before any suspend point (taking into account whether the initial coroutine suspend actually suspends or not). Although CP.53 recommends warning on any reference parameter regardless of whether the code onl

[PATCH] D140793: [clang-tidy] Implement CppCoreGuideline CP.53

ccotter created this revision. Herald added subscribers: carlosgalvezp, shchenz, kbarton, xazax.hun, nemanjai. Herald added a reviewer: njames93. Herald added a project: All. ccotter requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits