[PATCH] D140772: [clang-tidy] Fix minor bug in add_new_check.py

This revision was automatically updated to reflect the committed changes. Closed by commit rG210b731c01b0: [clang-tidy] Fix minor bug in add_new_check.py (authored by ccotter, committed by carlosgalvezp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D140772: [clang-tidy] Fix minor bug in add_new_check.py

carlosgalvezp added a comment. In D140772#4028570 , @ccotter wrote: > @carlosgalvezp - could you also help commit this if it looks good? Sure thing, thanks for the fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D140772: [clang-tidy] Fix minor bug in add_new_check.py

ccotter added a comment. @carlosgalvezp - could you also help commit this if it looks good? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140772/new/ https://reviews.llvm.org/D140772 ___ cfe-commits mail

[PATCH] D140772: [clang-tidy] Fix minor bug in add_new_check.py

carlosgalvezp accepted this revision. carlosgalvezp added a comment. Thanks for the fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140772/new/ https://reviews.llvm.org/D140772 ___ cfe-commits mailing

[PATCH] D140772: [clang-tidy] Fix minor bug in add_new_check.py

carlosgalvezp added inline comments. Comment at: clang-tools-extra/clang-tidy/add_new_check.py:324-328 doc_files = [] - for subdir in list(filter(lambda s: not s.endswith('.rst') and not s.endswith('.py'), - os.listdir(docs_dir))): + for subdir in list(f

[PATCH] D140772: [clang-tidy] Fix minor bug in add_new_check.py

carlosgalvezp added inline comments. Comment at: clang-tools-extra/clang-tidy/add_new_check.py:324-328 doc_files = [] - for subdir in list(filter(lambda s: not s.endswith('.rst') and not s.endswith('.py'), - os.listdir(docs_dir))): + for subdir in list(f

[PATCH] D140772: [clang-tidy] Fix minor bug in add_new_check.py

ccotter added inline comments. Comment at: clang-tools-extra/clang-tidy/add_new_check.py:324-328 doc_files = [] - for subdir in list(filter(lambda s: not s.endswith('.rst') and not s.endswith('.py'), - os.listdir(docs_dir))): + for subdir in list(filter(

[PATCH] D140772: [clang-tidy] Fix minor bug in add_new_check.py

ccotter updated this revision to Diff 485710. ccotter added a comment. Fix isdir check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140772/new/ https://reviews.llvm.org/D140772 Files: clang-tools-extra/clang-tidy/add_new_check.py clang-tools-

[PATCH] D140772: [clang-tidy] Fix minor bug in add_new_check.py

carlosgalvezp accepted this revision. carlosgalvezp added a comment. This revision is now accepted and ready to land. LGTM, I have a suggestion for further improvement. Comment at: clang-tools-extra/clang-tidy/add_new_check.py:324-328 doc_files = [] - for subdir in list(fil