[PATCH] D140724: [clang][Interp] Add back Run() call

2023-01-25 Thread Timm Bäder via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcb703434cbdc: [clang][Interp] Add back Run() call (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D140724: [clang][Interp] Add back Run() call

2023-01-13 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/AST/Interp/Interp.h:1301 assert(S.Current->getFunction()->hasRVO()); + if (S.checkingPotentialConstantExpression()) +return false;

[PATCH] D140724: [clang][Interp] Add back Run() call

2023-01-12 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder added inline comments. Comment at: clang/lib/AST/Interp/Interp.h:1301 assert(S.Current->getFunction()->hasRVO()); + if (S.checkingPotentialConstantExpression()) +return false; shafik wrote: > Why did you add these checks calling `checkingPotential

[PATCH] D140724: [clang][Interp] Add back Run() call

2023-01-12 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik added inline comments. Comment at: clang/lib/AST/Interp/Interp.h:1301 assert(S.Current->getFunction()->hasRVO()); + if (S.checkingPotentialConstantExpression()) +return false; Why did you add these checks calling `checkingPotentialConstantExpressio

[PATCH] D140724: [clang][Interp] Add back Run() call

2022-12-28 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We need to run the functions we compiled immediat