[PATCH] D140711: [clang] Fix unused variable warning in SemaConcept.cpp

2023-01-12 Thread Haojian Wu via Phabricator via cfe-commits
hokein added a comment. > Hey @hokein, thanks for the accept. I don't have commit rights, can you > please land this? Done. Sorry for the late response (I totally missed this). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140711/new/ https://rev

[PATCH] D140711: [clang] Fix unused variable warning in SemaConcept.cpp

2023-01-12 Thread Haojian Wu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGd0a98efb6819: [clang] Fix unused variable warning in SemaConcept.cpp (authored by Victor Komarov , committed by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D140711: [clang] Fix unused variable warning in SemaConcept.cpp

2023-01-12 Thread Haojian Wu via Phabricator via cfe-commits
hokein added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:1348 bool &Result) { if (const auto *FD1 = dyn_cast(D1)) { auto IsExpectedEntity = [](const FunctionDecl *FD) { cor3ntin wrote: > we still need th

[PATCH] D140711: [clang] Fix unused variable warning in SemaConcept.cpp

2023-01-03 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin added a comment. nit: I think that's a cleaner fix :) Comment at: clang/lib/Sema/SemaConcept.cpp:1348 bool &Result) { if (const auto *FD1 = dyn_cast(D1)) { auto IsExpectedEntity = [](const FunctionDecl *FD) {

[PATCH] D140711: [clang] Fix unused variable warning in SemaConcept.cpp

2023-01-03 Thread Victor K via Phabricator via cfe-commits
vctr added a comment. Hey @hokein, thanks for the accept. I don't have commit rights, can you please land this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140711/new/ https://reviews.llvm.org/D140711 ___

[PATCH] D140711: [clang] Fix unused variable warning in SemaConcept.cpp

2022-12-27 Thread Victor K via Phabricator via cfe-commits
vctr created this revision. Herald added a project: All. vctr requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D140711 Files: clang/lib/Sema/SemaConcept.cpp Index: clang/li