This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG499bf67208d9: [include-cleaner] Don't count references
to operators as uses (authored by hokein).
Changed prior to commit:
https://reviews.llvm.or
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clang-tools-extra/include-cleaner/lib/WalkAST.cpp:75
+// doesn't count as uses (generally the type should provide them).
+// Ignore them by trav
hokein added inline comments.
Comment at: clang-tools-extra/include-cleaner/lib/WalkAST.cpp:69
+ bool TraverseCXXOperatorCallExpr(CXXOperatorCallExpr *S) {
+// Operators are always ADL extension points, by design references to them
sammccall wrote:
> Rathe
hokein updated this revision to Diff 487382.
hokein marked an inline comment as done.
hokein added a comment.
update
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140551/new/
https://reviews.llvm.org/D140551
Files:
clang-tools-extra/include-clea
sammccall added a comment.
Yeah, I think this makes sense.
I think this sort of thing should ideally be captured in the include-cleaner
design doc if there was one. (Doesn't make sense to create one just for this
issue, but it seems like a doc that should exist).
Comment at:
hokein created this revision.
hokein added a reviewer: sammccall.
Herald added a subscriber: kadircet.
Herald added a project: All.
hokein requested review of this revision.
Herald added a project: clang-tools-extra.
Fixes https://github.com/llvm/llvm-project/issues/59655
Repository:
rG LLVM G
