This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
shchenz marked an inline comment as done.
Closed by commit rGb1d7010caa43: [DebugInfo] make DW_LANG_C11 respect
-gstrict-dwarf (authored by shchenz).
Repository:
rG
dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.
Looks good
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140544/new/
https://reviews.llvm.org/D140544
_
shchenz marked an inline comment as done.
shchenz added inline comments.
Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:582
} else if (LO.C11) {
-LangTag = llvm::dwarf::DW_LANG_C11;
+if (CGO.DebugStrictDwarf && CGO.DwarfVersion < 5)
+ LangTag = llvm::dwarf::DW_LANG
shchenz updated this revision to Diff 484994.
shchenz added a comment.
address @dblaikie comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140544/new/
https://reviews.llvm.org/D140544
Files:
clang/lib/CodeGen/CGDebugInfo.cpp
clang/test/Co
dblaikie added inline comments.
Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:582
} else if (LO.C11) {
-LangTag = llvm::dwarf::DW_LANG_C11;
+if (CGO.DebugStrictDwarf && CGO.DwarfVersion < 5)
+ LangTag = llvm::dwarf::DW_LANG_C;
Generally, I think,
shchenz created this revision.
shchenz added reviewers: dblaikie, probinson, aprantl.
shchenz added a project: LLVM.
Herald added a project: All.
shchenz requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Repository:
rG LLVM Github Monorepo
