[PATCH] D140532: .clang-tidy: disable misc-use-anonymous-namespace check.

2023-01-02 Thread Haojian Wu via Phabricator via cfe-commits
hokein added a comment. In D140532#4012879 , @sammccall wrote: > Yeah, good call. Do you mind if I first use this as a trigger to start a > thread about this style rule on discourse, though? I've been meaning to, it > came up in a review recently. sure

[PATCH] D140532: .clang-tidy: disable misc-use-anonymous-namespace check.

2022-12-22 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. Yeah, good call. Do you mind if I first use this as a trigger to start a thread about this style rule on discourse, though? I've been meaning to, it came up in a review recently. I think there's a fair chance of changing the policy from "require static" to "allow eit

[PATCH] D140532: .clang-tidy: disable misc-use-anonymous-namespace check.

2022-12-22 Thread Haojian Wu via Phabricator via cfe-commits
hokein created this revision. hokein added a reviewer: sammccall. Herald added a reviewer: njames93. Herald added a project: All. hokein requested review of this revision. Herald added subscribers: llvm-commits, aheejin. Herald added a project: LLVM. The check gives warnings on static functions, t