[PATCH] D140507: Parse: handle another case of invalid handling for attributes

2023-01-05 Thread Saleem Abdulrasool via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG179d24d764ac: Parse: handle another case of invalid handling for attributes (authored by compnerd). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140507/new/

[PATCH] D140507: Parse: handle another case of invalid handling for attributes

2023-01-05 Thread Saleem Abdulrasool via Phabricator via cfe-commits
compnerd added a comment. I think that the current release note should be sufficient. This is handling the same scenario in a different path. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140507/new/ https://reviews.llvm.org/D140507

[PATCH] D140507: Parse: handle another case of invalid handling for attributes

2023-01-04 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Should this also get a release note or do you think the current one covers it well enough? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D140507: Parse: handle another case of invalid handling for attributes

2022-12-21 Thread Saleem Abdulrasool via Phabricator via cfe-commits
compnerd created this revision. compnerd added a reviewer: aaron.ballman. Herald added a subscriber: jdoerfert. Herald added a project: All. compnerd requested review of this revision. Herald added a project: clang. clang would improperly disallow GNU attributes before C++ standard attributes when