[PATCH] D140275: [clangd] Tweak to add doxygen comment to the function declaration

dgoldman added a comment. In D140275#4203456 , @tupos wrote: > Could you please also advice me what else need to be done for the ObjC, since > there were many years since I wrote ObjC last time I'm not sure what else > need to be done there. > > Thanks.

[PATCH] D140275: [clangd] Tweak to add doxygen comment to the function declaration

tupos added a comment. Hi, could you please provide a code review again? Thanks. With best regards, Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140275/new/ https://reviews.llvm.org/D140275 ___ cfe-c

[PATCH] D140275: [clangd] Tweak to add doxygen comment to the function declaration

tupos added a comment. Could you please also advice me what else need to be done for the ObjC, since there were many years since I wrote ObjC last time I'm not sure what else need to be done there. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D140275: [clangd] Tweak to add doxygen comment to the function declaration

tupos added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/AddDoxygenComment.cpp:24 +namespace clang { +namespace clangd { +namespace { tschuett wrote: > You can merge this into `namespace clang::clangd`. I prefer not to do it, because all

[PATCH] D140275: [clangd] Tweak to add doxygen comment to the function declaration

tupos updated this revision to Diff 506220. tupos marked 11 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140275/new/ https://reviews.llvm.org/D140275 Files: clang-tools-extra/clangd/refactor/tweaks/AddDoxygenComment.cpp

[PATCH] D140275: [clangd] Tweak to add doxygen comment to the function declaration

tupos added a comment. Hi, sorry for the long delay, but actually in this particular moment I was working on addressing the comments. Therefore, I will push the updated patch soon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140275/new/ https:

[PATCH] D140275: [clangd] Tweak to add doxygen comment to the function declaration

dgoldman added a comment. Herald added a subscriber: ChuanqiXu. Hey, are you still planning to work on this? Otherwise, is it okay if I take over this patch to implement this feature? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140275/new/ https

[PATCH] D140275: [clangd] Tweak to add doxygen comment to the function declaration

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/AddDoxygenComment.cpp:37 +//* @param bar +//* @return +//*/ sammccall wrote: > I'm a bit concerned about people generating these `@param bar` and `@return` > and lea

[PATCH] D140275: [clangd] Tweak to add doxygen comment to the function declaration

sammccall added a comment. Sorry about the delay on this. This looks useful - I know a lot of people write comments in this style, whatever my own reservations :-) Comment at: clang-tools-extra/clangd/refactor/tweaks/AddDoxygenComment.cpp:30 +// Given: +// int func(int x, ch

[PATCH] D140275: [clangd] Tweak to add doxygen comment to the function declaration

tupos added a comment. Also I tried to use it now, and I'm not sure where it is a good idea to allow this tweak from within a function body. Because it is quite annoying that in every function you get this code action. On the other hand maybe it is ok to allow it from within the body, but the

[PATCH] D140275: [clangd] Tweak to add doxygen comment to the function declaration

tschuett added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/AddDoxygenComment.cpp:24 +namespace clang { +namespace clangd { +namespace { You can merge this into `namespace clang::clangd`. Comment at: clang-tools-extra/c

[PATCH] D140275: [clangd] Tweak to add doxygen comment to the function declaration

tupos added a comment. I do not know but maybe it makes sence to make configurable the style of the comment, e.g instead of `@brief` use `\brief` and the same for `/*!` to `/**` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140275/new/ https://rev

[PATCH] D140275: [clangd] Tweak to add doxygen comment to the function declaration

tupos created this revision. tupos added reviewers: sammccall, njames93. tupos added a project: clang-tools-extra. Herald added subscribers: kadircet, arphaman. Herald added a project: All. tupos requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Repo