[PATCH] D140222: [AArch64] Check 128-bit Sysreg Builtins

2023-01-23 Thread Sam Elliott via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG03ef89f8d909: [AArch64] Check 128-bit Sysreg Builtins (authored by lenary). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D140222: [AArch64] Check 128-bit Sysreg Builtins

2023-01-23 Thread Sam Elliott via Phabricator via cfe-commits
lenary added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:8297 << Arg->getSourceRange(); } else if (IsAArch64Builtin && Fields.size() == 1) { +// If this is a write ... tmatheson wrote: > It might be more readable to outline t

[PATCH] D140222: [AArch64] Check 128-bit Sysreg Builtins

2022-12-20 Thread Sam Elliott via Phabricator via cfe-commits
lenary marked 3 inline comments as done. lenary added a comment. Nits addressed. Will land in the new year, when I'm back at work. Right now it's time for a break! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140222/new/ https://reviews.llvm.org/

[PATCH] D140222: [AArch64] Check 128-bit Sysreg Builtins

2022-12-20 Thread Sam Elliott via Phabricator via cfe-commits
lenary edited the summary of this revision. lenary updated this revision to Diff 484281. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140222/new/ https://reviews.llvm.org/D140222 Files: clang/include/clang/Basic/BuiltinsAArch64.def clang/lib/He

[PATCH] D140222: [AArch64] Check 128-bit Sysreg Builtins

2022-12-20 Thread Tomas Matheson via Phabricator via cfe-commits
tmatheson accepted this revision. tmatheson added a comment. This revision is now accepted and ready to land. Couple of nits, since you will be updating this anyway after dropping D140221 , otherwise LGTM. Comment at: clang/lib/Sema/SemaChecki

[PATCH] D140222: [AArch64] Check 128-bit Sysreg Builtins

2022-12-16 Thread Sam Elliott via Phabricator via cfe-commits
lenary created this revision. Herald added a subscriber: kristof.beyls. Herald added a project: All. lenary requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch contains several related changes: 1. We move to using TARGET_BUILTIN for