stefanp added inline comments.
Comment at: clang/lib/Sema/SemaExpr.cpp:9072
auto GetNullability = [&Ctx](QualType Ty) {
+Optional Kind = Ty->getNullability();
merrymeerkat wrote:
> barannikov88 wrote:
> > This now gives a warning
> > `clang/lib/Sema/Sema
merrymeerkat added inline comments.
Comment at: clang/lib/Sema/SemaExpr.cpp:9072
auto GetNullability = [&Ctx](QualType Ty) {
+Optional Kind = Ty->getNullability();
barannikov88 wrote:
> This now gives a warning
> `clang/lib/Sema/SemaExpr.cpp:9072:27: war
barannikov88 added inline comments.
Comment at: clang/lib/Sema/SemaExpr.cpp:9072
auto GetNullability = [&Ctx](QualType Ty) {
+Optional Kind = Ty->getNullability();
This now gives a warning
`clang/lib/Sema/SemaExpr.cpp:9072:27: warning: lambda capture 'Ct
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG0da4cecfb6ad: [clang][dataflow] Remove unused argument in
getNullability (authored by merrymeerkat, committed by gribozavr).
Repository:
rG LLVM G
merrymeerkat updated this revision to Diff 483460.
merrymeerkat added a comment.
Fix formatting
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140104/new/
https://reviews.llvm.org/D140104
Files:
clang-tools-extra/clangd/unittests/DiagnosticsTests
merrymeerkat updated this revision to Diff 483355.
merrymeerkat added a comment.
Address review comment (add temporary overload)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140104/new/
https://reviews.llvm.org/D140104
Files:
clang-tools-extra/
merrymeerkat updated this revision to Diff 483345.
merrymeerkat added a comment.
Resolving review comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140104/new/
https://reviews.llvm.org/D140104
Files:
clang-tools-extra/clangd/unittests/Diag
gribozavr2 added inline comments.
Comment at: clang/include/clang/AST/Type.h:2550
/// be lost by canonicalization and desugaring.
- Optional getNullability(const ASTContext &context) const;
+ Optional getNullability() const;
Could you add a temporary depre
merrymeerkat created this revision.
Herald added subscribers: martong, kadircet, arphaman, xazax.hun.
Herald added a project: All.
merrymeerkat requested review of this revision.
Herald added projects: clang, clang-tools-extra.
Herald added a subscriber: cfe-commits.
This change will allow users t
