[PATCH] D139998: [clangd] Remove ReferenceFinder::Reference::Target

2022-12-16 Thread Nathan Ridge via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG40d29c0a714d: [clangd] Remove ReferenceFinder::Reference::Target (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D139998: [clangd] Remove ReferenceFinder::Reference::Target

2022-12-16 Thread Nathan Ridge via Phabricator via cfe-commits
nridge updated this revision to Diff 483623. nridge added a comment. address nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139998/new/ https://reviews.llvm.org/D139998 Files: clang-tools-extra/clangd/XRefs.cpp Index: clang-tools-extra/cla

[PATCH] D139998: [clangd] Remove ReferenceFinder::Reference::Target

2022-12-16 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Comment at: clang-tools-extra/clangd/XRefs.cpp:871 for (const NamedDecl *ND : Targets) { const Decl *CD = ND->getCanonicalDecl(); + TargetD

[PATCH] D139998: [clangd] Remove ReferenceFinder::Reference::Target

2022-12-14 Thread Nathan Ridge via Phabricator via cfe-commits
nridge created this revision. nridge added reviewers: tom-anders, kadircet. Herald added a subscriber: arphaman. Herald added a project: All. nridge requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. No one w