This revision was automatically updated to reflect the committed changes.
Closed by commit rG749c6a708340: [include-cleaner] Ranking of providers based
on hints (authored by kadircet).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139921/new/
https:
kadircet added inline comments.
Comment at:
clang-tools-extra/include-cleaner/include/clang-include-cleaner/Types.h:133
+
+ Header(std::in_place_t, decltype(Storage) Sentinel)
+ : Storage(std::move(Sentinel)) {}
sammccall wrote:
> this is a bit confusing..
kadircet updated this revision to Diff 491286.
kadircet marked 23 inline comments as done.
kadircet added a comment.
- Address comments & rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139921/new/
https://reviews.llvm.org/D139921
Files:
cl
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Herald added a subscriber: ChuanqiXu.
LG, just nits really!
Comment at:
clang-tools-extra/include-cleaner/include/clang-include-cleaner/Types.h:133
+
+ Header(std::in
kadircet updated this revision to Diff 487721.
kadircet marked 5 inline comments as done.
kadircet added a comment.
- Address all comments but the ones on tests.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139921/new/
https://reviews.llvm.org/D13
kadircet marked 26 inline comments as done.
kadircet added inline comments.
Comment at: clang-tools-extra/include-cleaner/lib/AnalysisInternal.h:84
+/// Represents properties of a symbol provider.
+enum class Hint : uint8_t {
sammccall wrote:
> along with `Symb
sammccall added inline comments.
Comment at: clang-tools-extra/include-cleaner/lib/AnalysisInternal.h:84
+/// Represents properties of a symbol provider.
+enum class Hint : uint8_t {
along with `SymbolLocation`, I think mixing our fundamental types and analysis
hokein added a comment.
I haven't read all code yet, left a few initial comments.
Comment at: clang-tools-extra/include-cleaner/lib/AnalysisInternal.h:85
+/// Represents properties of a symbol provider.
+enum class Hint : uint8_t {
+ None = 0x00,
IIUC, we're u
kadircet created this revision.
kadircet added reviewers: hokein, sammccall.
Herald added a subscriber: mgrang.
Herald added a project: All.
kadircet requested review of this revision.
Herald added a project: clang-tools-extra.
Herald added a subscriber: cfe-commits.
Introduce signals to rank prov
