rnk added a subscriber: hans.
rnk added a comment.
This feels to me like we are still working around some incompatibilities
between the MSVC intrin.h / intrin0.h model. I would prefer it if we could
always use `static inline` consistently in our intrinsic headers so we don't
have to worry about
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG3b0677964c46: Headers: use C++ inline semantics in C++ mode
(authored by compnerd).
Changed prior to commit:
https://reviews.llvm.org/D139749?vs=4
compnerd added a comment.
Thanks @fsb4000 (and @CaseyCarter)! I think that due to the shipped version,
it makes sense to do this still. Using standard semantics in general I think
is preferable, since nothing prevents another compiler implementation to still
do something similar.
CHANGES SI
fsb4000 added a subscriber: CaseyCarter.
fsb4000 added a comment.
@CaseyCarter created https://github.com/microsoft/STL/pull/3285
So MSVC STL don't use with Clang now. It should fix the issues too
because Clang overrides (and doesn't override)
CHANGES SINCE LAST ACTION
https://reviews.llvm.
compnerd updated this revision to Diff 483081.
compnerd retitled this revision from "Headers: make a couple of builtins
non-static" to "Headers: use C++ inline semantics in C++ mode".
compnerd edited the summary of this revision.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139749/new/
