[PATCH] D139749: Headers: make a couple of builtins non-static

2022-12-14 Thread Saleem Abdulrasool via Phabricator via cfe-commits
compnerd added a comment. Seems that this alone is insufficient as some build does run into issues, so I may need to refine this further. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139749/new/ https://reviews.llvm.org/D139749 _

[PATCH] D139749: Headers: make a couple of builtins non-static

2022-12-13 Thread Saleem Abdulrasool via Phabricator via cfe-commits
compnerd added a subscriber: STL_MSFT. compnerd added a comment. @fsb4000 is my reading correct that MSVC will look into trying to handle `static inline` even though it is a GNUism? I wonder if we should consider limiting the use of `static inline` to C mode rather than including C++. I also

[PATCH] D139749: Headers: make a couple of builtins non-static

2022-12-12 Thread Igor Zhukov via Phabricator via cfe-commits
fsb4000 accepted this revision. fsb4000 added a comment. This revision is now accepted and ready to land. I also asked at MS STL Discord(https://discord.gg/XWanNww) about the patch. F25588619: изображение.png Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D139749: Headers: make a couple of builtins non-static

2022-12-09 Thread Saleem Abdulrasool via Phabricator via cfe-commits
compnerd created this revision. compnerd added a reviewer: aaron.ballman. Herald added a project: All. compnerd requested review of this revision. Herald added a project: clang. When building with the 17.5.0 preview toolset for MSVC and building with modules, the definition of `_addcarry_u64` and