[PATCH] D139720: [clang][PPC] Checking Unknown Values Passed to -mcpu

This revision was automatically updated to reflect the committed changes. Closed by commit rG1fdbe5c573b9: [clang][PPC] Checking Unknown Values Passed to -mcpu (authored by Qiongsi Wu ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D139720: [clang][PPC] Checking Unknown Values Passed to -mcpu

jamieschmeiser accepted this revision. jamieschmeiser added a comment. This revision is now accepted and ready to land. LGTM Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139720/new/ https://reviews.llvm.org/D139720 __

[PATCH] D139720: [clang][PPC] Checking Unknown Values Passed to -mcpu

qiongsiwu1 added a comment. In D139720#3989651 , @jamieschmeiser wrote: > I'm fine with handling the return for common as a separate change, if > necessary. Sounds good! In this case I will fix it in a different patch once we decide what exactly to do

[PATCH] D139720: [clang][PPC] Checking Unknown Values Passed to -mcpu

jamieschmeiser added a comment. I'm fine with handling the return for common as a separate change, if necessary. Is the error produced now because it passes back the incorrect option rather than quietly changing it to something appropriate as it did before? Repository: rG LLVM Github Monorepo

[PATCH] D139720: [clang][PPC] Checking Unknown Values Passed to -mcpu

qiongsiwu1 marked 2 inline comments as done. qiongsiwu1 added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/PPC.cpp:77 + .Default(CPUName); +return TargetCPUName.str(); } jamieschmeiser wrote: > qiongsiwu1 wrote:

[PATCH] D139720: [clang][PPC] Checking Unknown Values Passed to -mcpu

qiongsiwu1 updated this revision to Diff 482137. qiongsiwu1 added a comment. Updating to revert back to `const char *` in the big `StringSwitch`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139720/new/ https://reviews.llvm.org/D139720 Files: c

[PATCH] D139720: [clang][PPC] Checking Unknown Values Passed to -mcpu

jamieschmeiser added a subscriber: hubert.reinterpretcast. jamieschmeiser added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/PPC.cpp:54 +auto TargetCPUName = llvm::StringSwitch(CPUName) + .Case("common", "generic") +

[PATCH] D139720: [clang][PPC] Checking Unknown Values Passed to -mcpu

qiongsiwu1 added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/PPC.cpp:54 +auto TargetCPUName = llvm::StringSwitch(CPUName) + .Case("common", "generic") + .Case("440fp", "440") jamieschme

[PATCH] D139720: [clang][PPC] Checking Unknown Values Passed to -mcpu

jamieschmeiser requested changes to this revision. jamieschmeiser added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Driver/ToolChains/Arch/PPC.cpp:54 +auto TargetCPUName = llvm::StringSwitch(CPUName) + .Cas

[PATCH] D139720: [clang][PPC] Checking Unknown Values Passed to -mcpu

qiongsiwu1 updated this revision to Diff 481739. qiongsiwu1 added a comment. Update to include a new test case against the unknown target error message. Thanks for the suggestion @amyk ! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139720/new/ https://reviews.llvm.org/D139720 Files:

[PATCH] D139720: [clang][PPC] Checking Unknown Values Passed to -mcpu

amyk added a comment. It might be good to add a test case to illustrate the 'unknown target CPU' error that is issued as a result of this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139720/new/ https://reviews.llvm.org/D139720 __

[PATCH] D139720: [clang][PPC] Checking Unknown Values Passed to -mcpu

qiongsiwu1 created this revision. qiongsiwu1 added reviewers: nemanjai, amyk. qiongsiwu1 added a project: clang. Herald added subscribers: shchenz, kbarton. Herald added a project: All. qiongsiwu1 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Currently `ppc::ge