This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG81c3739156fe: [include-cleaner] Use expansion locations for
macros. (authored by VitaNuo).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST
VitaNuo added a comment.
Thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139716/new/
https://reviews.llvm.org/D139716
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/
VitaNuo updated this revision to Diff 483941.
VitaNuo marked 4 inline comments as done.
VitaNuo added a comment.
Address review comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139716/new/
https://reviews.llvm.org/D139716
Files:
clang-too
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
Thanks!
Comment at: clang-tools-extra/include-cleaner/unittests/FindHeadersTest.cpp:176
+llvm::StringRef DeclareHeader;
+llvm::StringRef MacroHeader;
+ } TestCases[]
VitaNuo updated this revision to Diff 483927.
VitaNuo added a comment.
Remove extra variable.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139716/new/
https://reviews.llvm.org/D139716
Files:
clang-tools-extra/include-cleaner/lib/FindHeaders.cpp
VitaNuo added a comment.
Thanks for the review!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139716/new/
https://reviews.llvm.org/D139716
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://
VitaNuo updated this revision to Diff 483926.
VitaNuo marked 7 inline comments as done.
VitaNuo added a comment.
Address most recent review comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139716/new/
https://reviews.llvm.org/D139716
Files:
hokein added a comment.
thanks, the test looks better now, a few more suggestions.
Comment at: clang-tools-extra/include-cleaner/unittests/FindHeadersTest.cpp:162
+struct CustomVisitor : RecursiveASTVisitor {
+ const Decl *Out = nullptr;
Move the definition
VitaNuo marked an inline comment as done.
VitaNuo added inline comments.
Comment at: clang-tools-extra/include-cleaner/unittests/FindHeadersTest.cpp:161
+TEST_F(FindHeadersTest, TargetIsArgumentExpandedFromMacroInHeader) {
+ llvm::Annotations MainFile(R"cpp(
h
VitaNuo updated this revision to Diff 483911.
VitaNuo added a comment.
Add guard calls to headers.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139716/new/
https://reviews.llvm.org/D139716
Files:
clang-tools-extra/include-cleaner/lib/FindHeader
VitaNuo updated this revision to Diff 483910.
VitaNuo added a comment.
Address review comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139716/new/
https://reviews.llvm.org/D139716
Files:
clang-tools-extra/include-cleaner/lib/FindHeaders.c
hokein added a comment.
The implementation looks good. Some comments around the test.
Comment at: clang-tools-extra/include-cleaner/unittests/FindHeadersTest.cpp:161
+TEST_F(FindHeadersTest, TargetIsArgumentExpandedFromMacroInHeader) {
+ llvm::Annotations MainFile(R"cpp(
---
VitaNuo updated this revision to Diff 481635.
VitaNuo added a comment.
Remove FIXME.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139716/new/
https://reviews.llvm.org/D139716
Files:
clang-tools-extra/include-cleaner/lib/FindHeaders.cpp
clang-
VitaNuo created this revision.
Herald added a subscriber: kadircet.
Herald added a project: All.
VitaNuo requested review of this revision.
Herald added a project: clang-tools-extra.
Herald added a subscriber: cfe-commits.
Use expansion locations for target symbol decls when finding headers for ma
14 matches
Mail list logo
