[PATCH] D139701: [Clang] Don't emit "min-legal-vector-width"="0" for AMDGPU

2022-12-18 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added a comment. Please update the title Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139701/new/ https://reviews.llvm.org/D139701 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D139701: [Clang] Don't emit "min-legal-vector-width"="0" for AMDGPU

2022-12-17 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added a comment. In D139701#4003209 , @pengfei wrote: > In D139701#3993131 , @craig.topper > wrote: > >> I really think only X86 is using this. > > I'm still not sure of that. Please see the diff in

[PATCH] D139701: [Clang] Don't emit "min-legal-vector-width"="0" for AMDGPU

2022-12-17 Thread Phoebe Wang via Phabricator via cfe-commits
pengfei added a comment. In D139701#3993446 , @arsenm wrote: > TargetCodeGenInfo::setTargetAttributes already exists as a place for targets > to emit their custom attributes, x86 could emit it there It's an attractive suggestion. But it's not easy to mo

[PATCH] D139701: [Clang] Don't emit "min-legal-vector-width"="0" for AMDGPU

2022-12-13 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm added a comment. TargetCodeGenInfo::setTargetAttributes already exists as a place for targets to emit their custom attributes, x86 could emit it there Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139701/new/ https://reviews.llvm.org/D13970

[PATCH] D139701: [Clang] Don't emit "min-legal-vector-width"="0" for AMDGPU

2022-12-13 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added a comment. I really think only X86 is using this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139701/new/ https://reviews.llvm.org/D139701 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D139701: [Clang] Don't emit "min-legal-vector-width"="0" for AMDGPU

2022-12-09 Thread Phoebe Wang via Phabricator via cfe-commits
pengfei created this revision. pengfei added reviewers: craig.topper, arsenm, RKSimon. Herald added subscribers: kosarev, StephenFan, jdoerfert, kerbowa, tpr, dstuttard, yaxunl, jvesely, kzhuravl. Herald added a project: All. pengfei requested review of this revision. Herald added subscribers: cfe