This revision was automatically updated to reflect the committed changes.
Closed by commit rG3a58e11961d8: [lsan] Add lsan support for loongarch64
(authored by tangyouling, committed by SixWeining).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D13968
MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.
LGTM.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139686/new/
https://reviews.llvm.org/D139686
SixWeining added a comment.
LGTM. Is there any objection?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139686/new/
https://reviews.llvm.org/D139686
___
cfe-commits mailing list
cfe-commits@lists.llvm.or
tangyouling updated this revision to Diff 485349.
tangyouling added a comment.
rebase code.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139686/new/
https://reviews.llvm.org/D139686
Files:
clang/lib/Driver/ToolChains/Linux.cpp
clang/test/Driv
XiaodongLoong added a comment.
Please rebase code for test errors.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139686/new/
https://reviews.llvm.org/D139686
___
cfe-commits mailing list
cfe-commits@list
tangyouling added inline comments.
Comment at: compiler-rt/test/lsan/TestCases/swapcontext.cpp:8
// Missing 'getcontext' and 'makecontext' on Android.
-// UNSUPPORTED: arm,aarch64,powerpc64,android
+// UNSUPPORTED: arm,aarch64,loongarch64,powerpc64,android
Six
SixWeining added inline comments.
Comment at: compiler-rt/test/lsan/TestCases/swapcontext.cpp:8
// Missing 'getcontext' and 'makecontext' on Android.
-// UNSUPPORTED: arm,aarch64,powerpc64,android
+// UNSUPPORTED: arm,aarch64,loongarch64,powerpc64,android
Why
tangyouling updated this revision to Diff 481533.
tangyouling added a comment.
- Separate leak_check_segv.cpp modification.
- Add some comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139686/new/
https://reviews.llvm.org/D139686
Files:
cl
tangyouling added inline comments.
Comment at: compiler-rt/lib/lsan/lsan_common.cpp:281
+# elif defined(__loongarch_lp64)
+ return ((p >> 47) == 0);
# else
xen0n wrote:
> tangyouling wrote:
> > xen0n wrote:
> > > Since our VM layout is actually flexible, woul
xen0n added inline comments.
Comment at: compiler-rt/lib/lsan/lsan_common.cpp:281
+# elif defined(__loongarch_lp64)
+ return ((p >> 47) == 0);
# else
tangyouling wrote:
> xen0n wrote:
> > Since our VM layout is actually flexible, would it be better to documen
tangyouling added inline comments.
Comment at: compiler-rt/lib/lsan/lsan_common.cpp:281
+# elif defined(__loongarch_lp64)
+ return ((p >> 47) == 0);
# else
xen0n wrote:
> Since our VM layout is actually flexible, would it be better to document
> this, like "
xen0n added inline comments.
Comment at: compiler-rt/lib/lsan/lsan_common.cpp:281
+# elif defined(__loongarch_lp64)
+ return ((p >> 47) == 0);
# else
Since our VM layout is actually flexible, would it be better to document this,
like "Support only the most c
tangyouling added a comment.
$ cat memory-leak.c
#include
void *p;
int main() {
p = malloc(7);
p = 0; // The memory is leaked here.
return 0;
}
$ ./build/bin/clang -fsanitize=address -g memory-leak.c ;
ASAN_OPTIONS=detect_leaks=1 ./a.out
===
tangyouling created this revision.
tangyouling added reviewers: Sanitizers, vitalybuka, SixWeining, xen0n, xry111,
MaskRay, XiaodongLoong, lixing-star.
Herald added subscribers: Enna1, StephenFan, s.egerton, simoncook.
Herald added a project: All.
tangyouling requested review of this revision.
Her
14 matches
Mail list logo