[PATCH] D139686: [lsan] Add lsan support for loongarch64

2023-01-13 Thread Lu Weining via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG3a58e11961d8: [lsan] Add lsan support for loongarch64 (authored by tangyouling, committed by SixWeining). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D13968

[PATCH] D139686: [lsan] Add lsan support for loongarch64

2023-01-12 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139686/new/ https://reviews.llvm.org/D139686

[PATCH] D139686: [lsan] Add lsan support for loongarch64

2023-01-12 Thread Lu Weining via Phabricator via cfe-commits
SixWeining added a comment. LGTM. Is there any objection? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139686/new/ https://reviews.llvm.org/D139686 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D139686: [lsan] Add lsan support for loongarch64

2022-12-26 Thread Youling Tang via Phabricator via cfe-commits
tangyouling updated this revision to Diff 485349. tangyouling added a comment. rebase code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139686/new/ https://reviews.llvm.org/D139686 Files: clang/lib/Driver/ToolChains/Linux.cpp clang/test/Driv

[PATCH] D139686: [lsan] Add lsan support for loongarch64

2022-12-26 Thread Xiaodong Liu via Phabricator via cfe-commits
XiaodongLoong added a comment. Please rebase code for test errors. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139686/new/ https://reviews.llvm.org/D139686 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D139686: [lsan] Add lsan support for loongarch64

2022-12-09 Thread Youling Tang via Phabricator via cfe-commits
tangyouling added inline comments. Comment at: compiler-rt/test/lsan/TestCases/swapcontext.cpp:8 // Missing 'getcontext' and 'makecontext' on Android. -// UNSUPPORTED: arm,aarch64,powerpc64,android +// UNSUPPORTED: arm,aarch64,loongarch64,powerpc64,android Six

[PATCH] D139686: [lsan] Add lsan support for loongarch64

2022-12-09 Thread Lu Weining via Phabricator via cfe-commits
SixWeining added inline comments. Comment at: compiler-rt/test/lsan/TestCases/swapcontext.cpp:8 // Missing 'getcontext' and 'makecontext' on Android. -// UNSUPPORTED: arm,aarch64,powerpc64,android +// UNSUPPORTED: arm,aarch64,loongarch64,powerpc64,android Why

[PATCH] D139686: [lsan] Add lsan support for loongarch64

2022-12-09 Thread Youling Tang via Phabricator via cfe-commits
tangyouling updated this revision to Diff 481533. tangyouling added a comment. - Separate leak_check_segv.cpp modification. - Add some comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139686/new/ https://reviews.llvm.org/D139686 Files: cl

[PATCH] D139686: [lsan] Add lsan support for loongarch64

2022-12-08 Thread Youling Tang via Phabricator via cfe-commits
tangyouling added inline comments. Comment at: compiler-rt/lib/lsan/lsan_common.cpp:281 +# elif defined(__loongarch_lp64) + return ((p >> 47) == 0); # else xen0n wrote: > tangyouling wrote: > > xen0n wrote: > > > Since our VM layout is actually flexible, woul

[PATCH] D139686: [lsan] Add lsan support for loongarch64

2022-12-08 Thread WÁNG Xuěruì via Phabricator via cfe-commits
xen0n added inline comments. Comment at: compiler-rt/lib/lsan/lsan_common.cpp:281 +# elif defined(__loongarch_lp64) + return ((p >> 47) == 0); # else tangyouling wrote: > xen0n wrote: > > Since our VM layout is actually flexible, would it be better to documen

[PATCH] D139686: [lsan] Add lsan support for loongarch64

2022-12-08 Thread Youling Tang via Phabricator via cfe-commits
tangyouling added inline comments. Comment at: compiler-rt/lib/lsan/lsan_common.cpp:281 +# elif defined(__loongarch_lp64) + return ((p >> 47) == 0); # else xen0n wrote: > Since our VM layout is actually flexible, would it be better to document > this, like "

[PATCH] D139686: [lsan] Add lsan support for loongarch64

2022-12-08 Thread WÁNG Xuěruì via Phabricator via cfe-commits
xen0n added inline comments. Comment at: compiler-rt/lib/lsan/lsan_common.cpp:281 +# elif defined(__loongarch_lp64) + return ((p >> 47) == 0); # else Since our VM layout is actually flexible, would it be better to document this, like "Support only the most c

[PATCH] D139686: [lsan] Add lsan support for loongarch64

2022-12-08 Thread Youling Tang via Phabricator via cfe-commits
tangyouling added a comment. $ cat memory-leak.c #include void *p; int main() { p = malloc(7); p = 0; // The memory is leaked here. return 0; } $ ./build/bin/clang -fsanitize=address -g memory-leak.c ; ASAN_OPTIONS=detect_leaks=1 ./a.out ===

[PATCH] D139686: [lsan] Add lsan support for loongarch64

2022-12-08 Thread Youling Tang via Phabricator via cfe-commits
tangyouling created this revision. tangyouling added reviewers: Sanitizers, vitalybuka, SixWeining, xen0n, xry111, MaskRay, XiaodongLoong, lixing-star. Herald added subscribers: Enna1, StephenFan, s.egerton, simoncook. Herald added a project: All. tangyouling requested review of this revision. Her