[PATCH] D139629: clang: Stop emitting "strictfp"

arsenm closed this revision. arsenm added a comment. 42d4c85ca83f25f993444fb5bbaa58525f724991 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139629/new/ https://reviews.llvm.org/D139629 __

[PATCH] D139629: clang: Stop emitting "strictfp"

arsenm accepted this revision. arsenm added a comment. This revision is now accepted and ready to land. self accept after latest comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139629/new/ https://reviews.llvm.org/D139629 ___ cfe-commi

[PATCH] D139629: clang: Stop emitting "strictfp"

zahiraam added a comment. In D139629#4481408 , @rjmccall wrote: > In D139629#4481030 , @zahiraam > wrote: > >> According to this comment https://reviews.llvm.org/D87528#2342132, it looks >> like @rjmccall had pr

[PATCH] D139629: clang: Stop emitting "strictfp"

rjmccall added a comment. In D139629#4481030 , @zahiraam wrote: > According to this comment https://reviews.llvm.org/D87528#2342132, it looks > like @rjmccall had proposed the addition of the attribute. @rjmccall Do you > recall why it was added? My su

[PATCH] D139629: clang: Stop emitting "strictfp"

zahiraam added a subscriber: rjmccall. zahiraam added a comment. According to this comment https://reviews.llvm.org/D87528#2342132, it looks like @rjmccall had proposed the addition of the attribute. @rjmccall Do you recall why it was added? CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D139629: clang: Stop emitting "strictfp"

arsenm added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139629/new/ https://reviews.llvm.org/D139629 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D139629: clang: Stop emitting "strictfp"

arsenm added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139629/new/ https://reviews.llvm.org/D139629 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D139629: clang: Stop emitting "strictfp"

kpn added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:2135 -llvm::AttrBuilder FuncAttrs(F->getContext()); -FuncAttrs.addAttribute("strictfp"); -F->addFnAttrs(FuncAttrs); arsenm wrote: > kpn wrote: > > arsenm wrote: > > > andrew.w.

[PATCH] D139629: clang: Stop emitting "strictfp"

arsenm added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:2135 -llvm::AttrBuilder FuncAttrs(F->getContext()); -FuncAttrs.addAttribute("strictfp"); -F->addFnAttrs(FuncAttrs); kpn wrote: > arsenm wrote: > > andrew.w.kaylor wrote: > >

[PATCH] D139629: clang: Stop emitting "strictfp"

kpn added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:2135 -llvm::AttrBuilder FuncAttrs(F->getContext()); -FuncAttrs.addAttribute("strictfp"); -F->addFnAttrs(FuncAttrs); arsenm wrote: > andrew.w.kaylor wrote: > > arsenm wrote: > >

[PATCH] D139629: clang: Stop emitting "strictfp"

arsenm added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:2135 -llvm::AttrBuilder FuncAttrs(F->getContext()); -FuncAttrs.addAttribute("strictfp"); -F->addFnAttrs(FuncAttrs); andrew.w.kaylor wrote: > arsenm wrote: > > zahiraam wrote

[PATCH] D139629: clang: Stop emitting "strictfp"

andrew.w.kaylor added a subscriber: erichkeane. andrew.w.kaylor added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:2135 -llvm::AttrBuilder FuncAttrs(F->getContext()); -FuncAttrs.addAttribute("strictfp"); -F->addFnAttrs(FuncAttrs);

[PATCH] D139629: clang: Stop emitting "strictfp"

arsenm added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:2135 -llvm::AttrBuilder FuncAttrs(F->getContext()); -FuncAttrs.addAttribute("strictfp"); -F->addFnAttrs(FuncAttrs); zahiraam wrote: > I think it would better to fix this fun

[PATCH] D139629: clang: Stop emitting "strictfp"

zahiraam added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:2135 -llvm::AttrBuilder FuncAttrs(F->getContext()); -FuncAttrs.addAttribute("strictfp"); -F->addFnAttrs(FuncAttrs); I think it would better to fix this function instead of

[PATCH] D139629: clang: Stop emitting "strictfp"

arsenm added a comment. In D139629#3982052 , @arsenm wrote: > In D139629#3981991 , @zahiraam > wrote: > >> Can you please be more verbose in your summary? This change is related to >> the use of -ffp-exception-b

[PATCH] D139629: clang: Stop emitting "strictfp"

arsenm added a comment. In D139629#3981991 , @zahiraam wrote: > Can you please be more verbose in your summary? This change is related to the > use of -ffp-exception-behavior=strict right? > This attribute is set here > https://github.com/llvm/llvm-pro

[PATCH] D139629: clang: Stop emitting "strictfp"

zahiraam added a comment. Can you please be more verbose in your summary? This change is related to the use of -ffp-exception-behavior=strict right? This attribute is set here https://github.com/llvm/llvm-project/blob/main/clang/lib/CodeGen/CodeGenFunction.cpp#L987 but under a condition. Is th

[PATCH] D139629: clang: Stop emitting "strictfp"

kpn added a comment. It looks like clang does have at least one test that checks for the strictfp attribute on function definitions. We also have a number that test for the strictfp attribute on function calls. So I think our test coverage is in good shape. LGTM. CHANGES SINCE LAST ACTION

[PATCH] D139629: clang: Stop emitting "strictfp"

arsenm created this revision. arsenm added reviewers: mibintc, john.brawn, kpn, jcranmer-intel, sepavloff, zahiraam. Herald added a project: All. arsenm requested review of this revision. Herald added a subscriber: wdng. The attribute is a proper enum attribute, strictfp. We were getting strictfp