[PATCH] D139564: clang: Don't emit "frame-pointer"="none"

2023-01-03 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm closed this revision. arsenm added a comment. ce6ae0b2a26b1ec2f770b2b9474cc4486d60c586 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139564/new/ https://reviews.llvm.org/D139564 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D139564: clang: Don't emit "frame-pointer"="none"

2023-01-03 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. Seems fine. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139564/new/ https://reviews.llvm.org/D139564 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

[PATCH] D139564: clang: Don't emit "frame-pointer"="none"

2023-01-03 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139564/new/ https://reviews.llvm.org/D139564 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D139564: clang: Don't emit "frame-pointer"="none"

2022-12-19 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm updated this revision to Diff 483964. arsenm added a comment. Add unreachable CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139564/new/ https://reviews.llvm.org/D139564 Files: clang/include/clang/Basic/CodeGenOptions.h clang/lib/CodeGen/CGCall.cpp clang/test/CodeGen/libcal

[PATCH] D139564: clang: Don't emit "frame-pointer"="none"

2022-12-07 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added reviewers: rjmccall, efriedma. aaron.ballman added a comment. Adding codegen code owners in for awareness, but in general I think this is a good cleanup. Thank you! Assuming the bots are happy, this LGTM, but please give the codegen folks a chance to speak up before landing.

[PATCH] D139564: clang: Don't emit "frame-pointer"="none"

2022-12-07 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm created this revision. arsenm added a reviewer: aaron.ballman. Herald added subscribers: kosarev, jdoerfert, jvesely. Herald added a project: All. arsenm requested review of this revision. Herald added subscribers: sstefan1, wdng. Herald added a reviewer: jdoerfert. This is the default beha