This revision was automatically updated to reflect the committed changes.
Closed by commit rG0a7ca8036058: Fix parameter name in Sema::addInitCapture to
ByRef. (authored by massberg).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139541/new/
https:/
massberg updated this revision to Diff 529312.
massberg added a comment.
Fix formatting (once again).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139541/new/
https://reviews.llvm.org/D139541
Files:
clang/include/clang/Sema/Sema.h
clang/lib/S
massberg updated this revision to Diff 529293.
massberg added a comment.
Fix formatting.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139541/new/
https://reviews.llvm.org/D139541
Files:
clang/include/clang/Sema/Sema.h
clang/lib/Sema/SemaLambd
massberg updated this revision to Diff 529277.
massberg added a comment.
Use correct format for burprone-argument-comment.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139541/new/
https://reviews.llvm.org/D139541
Files:
clang/include/clang/Sema
shafik added inline comments.
Comment at: clang/lib/Sema/SemaLambda.cpp:892-894
+ LSI->addCapture(Var, /*isBlock*/ false, ByRef,
/*isNested*/ false, Var->getLocation(), SourceLocation(),
Var->getType(), /*Invalid*/ false);
T
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM. BTW, feel free to send small changes like these without review. The
common jargon for them in LLVM is NFC (non-functional change)
Repository:
rG LLVM Github Monorepo
CH
massberg created this revision.
massberg added a reviewer: ilya-biryukov.
Herald added a project: All.
massberg requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Rename parameter in Sema::addInitCapture as proposed in review of
Sema::addInit
