[PATCH] D139525: Add implementation isTargetCanonicalConstantNode for hexagon.

2022-12-07 Thread Haojian Wu via Phabricator via cfe-commits
hokein added inline comments. Comment at: llvm/test/CodeGen/Hexagon/infinite-loop.ll:1 +; RUN: ll < %s + oops, forget to fix typo here (to verify the test), fixed in 3abdd9b91bc17541e78de6251043e178efe0e3ee. Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D139525: Add implementation isTargetCanonicalConstantNode for hexagon.

2022-12-07 Thread Haojian Wu via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa2215149aeb7: Add implementation isTargetCanonicalConstantNode for hexagon. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D139525: Add implementation isTargetCanonicalConstantNode for hexagon.

2022-12-07 Thread Benjamin Kramer via Phabricator via cfe-commits
bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. Looks good, thanks. Let's land this now to unbreak things. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139525/new/ https://reviews.llvm.org/

[PATCH] D139525: Add implementation isTargetCanonicalConstantNode for hexagon.

2022-12-07 Thread Haojian Wu via Phabricator via cfe-commits
hokein added a comment. In D139525#3977834 , @bkramer wrote: > Mind moving the test case from `llvm/test/CodeGen/AArch64` to > `llvm/test/CodeGen/Hexagon`? sure, done! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D139525: Add implementation isTargetCanonicalConstantNode for hexagon.

2022-12-07 Thread Haojian Wu via Phabricator via cfe-commits
hokein updated this revision to Diff 480850. hokein added a comment. move to a new directory Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139525/new/ https://reviews.llvm.org/D139525 Files: llvm/lib/Target/Hexagon/HexagonISelLowering.cpp llvm

[PATCH] D139525: Add implementation isTargetCanonicalConstantNode for hexagon.

2022-12-07 Thread Benjamin Kramer via Phabricator via cfe-commits
bkramer added a comment. Mind moving the test case from `llvm/test/CodeGen/AArch64` to `llvm/test/CodeGen/Hexagon`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139525/new/ https://reviews.llvm.org/D139525 ___

[PATCH] D139525: Add implementation isTargetCanonicalConstantNode for hexagon.

2022-12-07 Thread Haojian Wu via Phabricator via cfe-commits
hokein added a comment. In D139525#3977799 , @dmgreen wrote: > Can you add the test cases from D137140 ? Added one (I'm not familiar with this part of code, suggestions are welcome). Repository: rG LLVM Github Monore

[PATCH] D139525: Add implementation isTargetCanonicalConstantNode for hexagon.

2022-12-07 Thread Haojian Wu via Phabricator via cfe-commits
hokein updated this revision to Diff 480843. hokein added a comment. add a testcase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139525/new/ https://reviews.llvm.org/D139525 Files: llvm/lib/Target/Hexagon/HexagonISelLowering.cpp llvm/lib/Targ

[PATCH] D139525: Add implementation isTargetCanonicalConstantNode for hexagon.

2022-12-07 Thread Dave Green via Phabricator via cfe-commits
dmgreen added a reviewer: kparzysz. dmgreen added a comment. Can you add the test cases from D137140 ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139525/new/ https://reviews.llvm.org/D139525 ___

[PATCH] D139525: Add implementation isTargetCanonicalConstantNode for hexagon.

2022-12-07 Thread Haojian Wu via Phabricator via cfe-commits
hokein created this revision. hokein added reviewers: dmgreen, reames. Herald added a subscriber: hiraditya. Herald added a project: All. hokein requested review of this revision. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. This fixes an infinite compiling loop caused by