[PATCH] D139496: [CMake] Add perf profiling for clang-bolt

2023-02-08 Thread Amir Ayupov via Phabricator via cfe-commits
Amir abandoned this revision. Amir added a comment. Abandon in favor of D143553 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139496/new/ https://reviews.llvm.org/D139496 _

[PATCH] D139496: [CMake] Add perf profiling for clang-bolt

2022-12-21 Thread Amir Ayupov via Phabricator via cfe-commits
Amir updated this revision to Diff 484727. Amir added a comment. Convert perf profile using perf2bolt (aggregate-only mode) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139496/new/ https://reviews.llvm.org/D139496 Files: clang/CMakeLists.txt

[PATCH] D139496: [CMake] Add perf profiling for clang-bolt

2022-12-19 Thread Amir Ayupov via Phabricator via cfe-commits
Amir updated this revision to Diff 484102. Amir added a comment. Typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139496/new/ https://reviews.llvm.org/D139496 Files: clang/CMakeLists.txt clang/cmake/caches/BOLT.cmake llvm/docs/AdvancedBuil

[PATCH] D139496: [CMake] Add perf profiling for clang-bolt

2022-12-15 Thread Amir Ayupov via Phabricator via cfe-commits
Amir added a comment. @phosek – this diff adds support for AArch64 via Linux perf. I believe it makes sense to add this functionality first in an incremental fashion and refactor it later, moving parts into perf-training script. What do you think? (And thank you for reviewing this stuff!) Rep

[PATCH] D139496: [CMake] Add perf profiling for clang-bolt

2022-12-15 Thread Amir Ayupov via Phabricator via cfe-commits
Amir updated this revision to Diff 483400. Amir added a comment. Generalize to -DCLANG_BOLT={Instrument,perf,LBR}, update documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139496/new/ https://reviews.llvm.org/D139496 Files: clang/CMake

[PATCH] D139496: [CMake] Add perf profiling for clang-bolt

2022-12-10 Thread Amir Ayupov via Phabricator via cfe-commits
Amir added a comment. In D139496#3986435 , @phosek wrote: > Could we add the `perf` related logic to > https://github.com/llvm/llvm-project/blob/ba3d808feedaa7f31750d8bc02754e15b372c868/clang/utils/perf-training/perf-helper.py? > I think that's a better

[PATCH] D139496: [CMake] Add perf profiling for clang-bolt

2022-12-10 Thread Petr Hosek via Phabricator via cfe-commits
phosek added a comment. Could we add the `perf` related logic to https://github.com/llvm/llvm-project/blob/ba3d808feedaa7f31750d8bc02754e15b372c868/clang/utils/perf-training/perf-helper.py? I think that's a better place since we eventually want to replace the use of `ExternalProject_Add` with