[PATCH] D139326: [clang] Add test for CWG952

2023-01-23 Thread Vlad Serebrennikov via Phabricator via cfe-commits
Endill added inline comments. Comment at: clang/test/CXX/drs/dr9xx.cpp:76 +namespace dr952 { // dr952: yes +struct A { + typedef int I; // #dr952-typedef-decl aaron.ballman wrote: > I wouldn't mind another test case: > ``` > struct A { > protected: > static in

[PATCH] D139326: [clang] Add test for CWG952

2022-12-06 Thread Vlad Serebrennikov via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5b22c5129c11: [clang] Add test for CWG952 (authored by Endill). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D139326: [clang] Add test for CWG952

2022-12-05 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM, though I would appreciate another test (that I expect to pass). Comment at: clang/test/CXX/drs/dr9xx.cpp:76 +namespace dr952 { // dr952: yes +struct A { + typedef int I; // #dr952-typedef-decl -

[PATCH] D139326: [clang] Add test for CWG952

2022-12-05 Thread Erich Keane via Phabricator via cfe-commits
erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. This appears right to me! I'd like others to take a look though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139326/new/ https://revi

[PATCH] D139326: [clang] Add test for CWG952

2022-12-05 Thread Vlad Serebrennikov via Phabricator via cfe-commits
Endill created this revision. Endill added a reviewer: clang-language-wg. Herald added a project: All. Endill requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. P1787 : // CWG952 is r