[PATCH] D139287: [OpenMP] Introduce basic JIT support to OpenMP target offloading

jhuber6 added a comment. In D139287#4031503 , @hbae wrote: > In D139287#4031473 , @jhuber6 wrote: > >> In D139287#4031469 , @hbae wrote: >> >>> Looks like GCC 7.5 cannot b

[PATCH] D139287: [OpenMP] Introduce basic JIT support to OpenMP target offloading

hbae added a comment. In D139287#4031473 , @jhuber6 wrote: > In D139287#4031469 , @hbae wrote: > >> Looks like GCC 7.5 cannot build LLVM after this change. Could you please >> take a look? >> >> In file include

[PATCH] D139287: [OpenMP] Introduce basic JIT support to OpenMP target offloading

jhuber6 added a comment. In D139287#4031469 , @hbae wrote: > Looks like GCC 7.5 cannot build LLVM after this change. Could you please take > a look? > > In file included from > /localdisk/hbae/LLVM/llvm-base/openmp/libomptarget/plugins-nextgen/common/

[PATCH] D139287: [OpenMP] Introduce basic JIT support to OpenMP target offloading

hbae added a comment. Looks like GCC 7.5 cannot build LLVM after this change. Could you please take a look? In file included from /localdisk/hbae/LLVM/llvm-base/openmp/libomptarget/plugins-nextgen/common/PluginInterface/PluginInterface.cpp:11:0: /localdisk/hbae/LLVM/llvm-base/openmp/libomp

[PATCH] D139287: [OpenMP] Introduce basic JIT support to OpenMP target offloading

ye-luo added a comment. Got tons of runtime failure target doesn't support jit UNREACHABLE executed at /gpfs/jlse-fs0/users/yeluo/opt/llvm-clang/llvm-project-nightly/openmp/libomptarget/plugins-nextgen/common/PluginInterface/PluginInterface.h:543! on AMD GPU gfx908 when running miniqmc ctes

[PATCH] D139287: [OpenMP] Introduce basic JIT support to OpenMP target offloading

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. tianshilei1992 marked an inline comment as done. Closed by commit rG5a3a527f8ae2: [OpenMP] Introduce basic JIT support to OpenMP target offloading (authored by tianshil

[PATCH] D139287: [OpenMP] Introduce basic JIT support to OpenMP target offloading

tianshilei1992 updated this revision to Diff 485451. tianshilei1992 added a comment. fix compile error Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139287/new/ https://reviews.llvm.org/D139287 Files: openmp/libomptarget/CMakeLists.txt openmp/

[PATCH] D139287: [OpenMP] Introduce basic JIT support to OpenMP target offloading

tianshilei1992 added a comment. In D139287#4018071 , @ronlieb wrote: > seems like this broke the amdgpu buildbot , plz resolve > https://lab.llvm.org/buildbot/#/builders/193/builds/24122 Reverted. Will fix it soon. Repository: rG LLVM Github Monorepo

[PATCH] D139287: [OpenMP] Introduce basic JIT support to OpenMP target offloading

ronlieb added a comment. seems like this broke the amdgpu buildbot , plz resolve https://lab.llvm.org/buildbot/#/builders/193/builds/24122 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139287/new/ https://reviews.llvm.org/D139287 _

[PATCH] D139287: [OpenMP] Introduce basic JIT support to OpenMP target offloading

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. tianshilei1992 marked an inline comment as done. Closed by commit rG58906e4901ec: [OpenMP] Introduce basic JIT support to OpenMP target offloading (authored by tianshil

[PATCH] D139287: [OpenMP] Introduce basic JIT support to OpenMP target offloading

tianshilei1992 marked an inline comment as done. tianshilei1992 added inline comments. Comment at: openmp/libomptarget/plugins-nextgen/common/PluginInterface/JIT.cpp:276-277 + + StringRef RawData(CGOutputBuffer.begin(), CGOutputBuffer.size()); + return MemoryBuffer::getMemBuff

[PATCH] D139287: [OpenMP] Introduce basic JIT support to OpenMP target offloading

tianshilei1992 updated this revision to Diff 485406. tianshilei1992 added a comment. rebase and fix comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139287/new/ https://reviews.llvm.org/D139287 Files: openmp/libomptarget/CMakeLists.txt op

[PATCH] D139287: [OpenMP] Introduce basic JIT support to OpenMP target offloading

jhuber6 added inline comments. Comment at: openmp/libomptarget/plugins-nextgen/common/PluginInterface/JIT.cpp:276-277 + + StringRef RawData(CGOutputBuffer.begin(), CGOutputBuffer.size()); + return MemoryBuffer::getMemBufferCopy(RawData); +} tianshilei1992 wrot

[PATCH] D139287: [OpenMP] Introduce basic JIT support to OpenMP target offloading

tianshilei1992 added inline comments. Comment at: openmp/libomptarget/plugins-nextgen/common/PluginInterface/JIT.cpp:276-277 + + StringRef RawData(CGOutputBuffer.begin(), CGOutputBuffer.size()); + return MemoryBuffer::getMemBufferCopy(RawData); +} jhuber6 wrot

[PATCH] D139287: [OpenMP] Introduce basic JIT support to OpenMP target offloading

tianshilei1992 updated this revision to Diff 485375. tianshilei1992 marked 10 inline comments as done. tianshilei1992 added a comment. rebase and fix comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139287/new/ https://reviews.llvm.org/D13928

[PATCH] D139287: [OpenMP] Introduce basic JIT support to OpenMP target offloading

tianshilei1992 marked an inline comment as done. tianshilei1992 added inline comments. Comment at: openmp/libomptarget/plugins-nextgen/common/PluginInterface/JIT.cpp:184 + + auto AddStream = + [&](size_t Task, jdoerfert wrote: > jhuber6 wrote: > > tianshil

[PATCH] D139287: [OpenMP] Introduce basic JIT support to OpenMP target offloading

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG as there seem to be only nits left. We can expand on this in tree Comment at: openmp/libomptarget/plugins-nextgen/common/PluginInterface/JIT.cpp:184 + + auto AddSt

[PATCH] D139287: [OpenMP] Introduce basic JIT support to OpenMP target offloading

jhuber6 added a comment. Some nits. Comment at: openmp/libomptarget/plugins-nextgen/common/PluginInterface/JIT.cpp:132 + +OptimizationLevel getptLevel(unsigned OptLevel) { + switch (OptLevel) { typo Comment at: openmp/libomptarget/plugins-

[PATCH] D139287: [OpenMP] Introduce basic JIT support to OpenMP target offloading

tianshilei1992 marked an inline comment as done and an inline comment as not done. tianshilei1992 added inline comments. Comment at: openmp/cmake/OpenMPTesting.cmake:6 function(find_standalone_test_dependencies) - include(FindPythonInterp) + find_package(Python3 COMPONENTS In

[PATCH] D139287: [OpenMP] Introduce basic JIT support to OpenMP target offloading

tianshilei1992 updated this revision to Diff 482168. tianshilei1992 added a comment. add env for opt level Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139287/new/ https://reviews.llvm.org/D139287 Files: openmp/cmake/OpenMPTesting.cmake openm