[PATCH] D139277: [clangd] Use all query-driver arguments in cache key

nridge added a comment. This was superseded by D146941 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139277/new/ https://reviews.llvm.org/D139277 ___ cfe-commits maili

[PATCH] D139277: [clangd] Use all query-driver arguments in cache key

nridge added a comment. @ehntoo hi! are you planning to update this patch to address Kadir's comments? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139277/new/ https://reviews.llvm.org/D139277 ___ cfe-c

[PATCH] D139277: [clangd] Use all query-driver arguments in cache key

kadircet added a comment. thanks a lot for taking a look at this! Comment at: clang-tools-extra/clangd/SystemIncludeExtractor.cpp:301 llvm::StringRef Lang; +llvm::SmallVector AdditionalDriverArgs; + can we introduce a struct instead? ``` struct DriverA

[PATCH] D139277: [clangd] Use all query-driver arguments in cache key

ehntoo created this revision. ehntoo added reviewers: kadircet, nridge. ehntoo added a project: clang-tools-extra. Herald added a subscriber: arphaman. Herald added a project: All. ehntoo requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Rework the cache key cons