[PATCH] D139257: [clang-format] Link the braces of a block in UnwrappedLineParser

2022-12-09 Thread Björn Schäpers via Phabricator via cfe-commits
HazardyKnusperkeks added a comment. In D139257#3983332 , @owenpan wrote: > I have second thoughts about linking block braces in `UnwrappedLineParser`. > Consider the following example: > > #if A > while (a) { // Linked to the r_brace below > #else

[PATCH] D139257: [clang-format] Link the braces of a block in UnwrappedLineParser

2022-12-08 Thread Owen Pan via Phabricator via cfe-commits
owenpan added a comment. See https://github.com/llvm/llvm-project/issues/59417. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139257/new/ https://reviews.llvm.org/D139257 ___ cfe-commits mailing list cfe

[PATCH] D139257: [clang-format] Link the braces of a block in UnwrappedLineParser

2022-12-08 Thread Owen Pan via Phabricator via cfe-commits
owenpan added a comment. I have second thoughts about linking block braces in `UnwrappedLineParser`. Consider the following example: #if A while (a) { // Linked to the r_brace below #else while(b) { // Also linked to the r_brace below #endif foo(); } // Linked to the l_brace of

[PATCH] D139257: [clang-format] Link the braces of a block in UnwrappedLineParser

2022-12-04 Thread Owen Pan via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe33243c950ac: [clang-format] Link the braces of a block in UnwrappedLineParser (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES