[PATCH] D139090: [clang] Add test for CWG360

2022-12-01 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added inline comments. Comment at: clang/test/CXX/drs/dr3xx.cpp:908 +public: + using A::baz; // #dr360-baz-using-decl +}; aaron.ballman wrote: > Endill wrote: > > erichkeane wrote: > > > This bookmark isn't necessary, so no reason to have it. But tha

[PATCH] D139090: [clang] Add test for CWG360

2022-12-01 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang/test/CXX/drs/dr3xx.cpp:908 +public: + using A::baz; // #dr360-baz-using-decl +}; Endill wrote: > erichkeane wrote: > > This bookmark isn't necessary, so no reason to have it. But thank you for > > using th

[PATCH] D139090: [clang] Add test for CWG360

2022-12-01 Thread Vlad Serebrennikov via Phabricator via cfe-commits
Endill added inline comments. Comment at: clang/test/CXX/drs/dr3xx.cpp:908 +public: + using A::baz; // #dr360-baz-using-decl +}; erichkeane wrote: > This bookmark isn't necessary, so no reason to have it. But thank you for > using these! Nice catch, thank you!

[PATCH] D139090: [clang] Add test for CWG360

2022-12-01 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added inline comments. Comment at: clang/test/CXX/drs/dr3xx.cpp:908 +public: + using A::baz; // #dr360-baz-using-decl +}; This bookmark isn't necessary, so no reason to have it. But thank you for using these! Repository: rG LLVM Github Monorepo

[PATCH] D139090: [clang] Add test for CWG360

2022-12-01 Thread Vlad Serebrennikov via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3f950ad58919: [clang] Add test for CWG360 (authored by Endill). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D139090: [clang] Add test for CWG360

2022-12-01 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139090/new/ https://reviews.llvm.org/D139090 ___ cfe-commits mailing lis

[PATCH] D139090: [clang] Add test for CWG360

2022-12-01 Thread Vlad Serebrennikov via Phabricator via cfe-commits
Endill updated this revision to Diff 479225. Endill added a comment. run make_cxx_dr_status CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139090/new/ https://reviews.llvm.org/D139090 Files: clang/test/CXX/drs/dr3xx.cpp clang/www/cxx_dr_status.html Index: clang/www/cxx_dr_status.h

[PATCH] D139090: [clang] Add test for CWG360

2022-12-01 Thread Vlad Serebrennikov via Phabricator via cfe-commits
Endill created this revision. Endill added a reviewer: clang-language-wg. Herald added a project: All. Endill requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. P1787 : "CWG360 is resolved by applying access co