This revision was automatically updated to reflect the committed changes.
Closed by commit rG516e30175256: [NFC][Profile] Access profile through
VirtualFileSystem (authored by steven_wu).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139052/new/
htt
steven_wu updated this revision to Diff 493768.
steven_wu added a comment.
Try fix pre-merge build failure
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139052/new/
https://reviews.llvm.org/D139052
Files:
clang/include/clang/CodeGen/BackendUtil.
steven_wu updated this revision to Diff 493724.
steven_wu added a comment.
Rebase to main.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139052/new/
https://reviews.llvm.org/D139052
Files:
clang/include/clang/CodeGen/BackendUtil.h
clang/lib/Co
steven_wu updated this revision to Diff 487597.
steven_wu added a comment.
Address review feedback. Remove NFC from title.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139052/new/
https://reviews.llvm.org/D139052
Files:
clang/include/clang/Code
akyrtzi added inline comments.
Comment at: llvm/include/llvm/Support/PGOOptions.h:18
#include "llvm/Support/Error.h"
+#include "llvm/Support/VirtualFileSystem.h"
steven_wu wrote:
> akyrtzi wrote:
> > akyrtzi wrote:
> > > I'd suggest to consider moving the `PGO
steven_wu added inline comments.
Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1729
+ if (!Opts.ProfileInstrumentUsePath.empty()) {
+auto FS = llvm::vfs::getRealFileSystem();
+setPGOUseInstrumentor(Opts, Opts.ProfileInstrumentUsePath, *FS, Diags);
---
akyrtzi added inline comments.
Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1729
+ if (!Opts.ProfileInstrumentUsePath.empty()) {
+auto FS = llvm::vfs::getRealFileSystem();
+setPGOUseInstrumentor(Opts, Opts.ProfileInstrumentUsePath, *FS, Diags);
benlangmuir accepted this revision.
benlangmuir added a comment.
This revision is now accepted and ready to land.
All my comments are addressed, thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139052/new/
https://reviews.llvm.org/D139052
___
steven_wu added inline comments.
Comment at: clang/lib/CodeGen/CodeGenAction.cpp:164
LLVMIRGenerationRefCount(0),
- Gen(CreateLLVMCodeGen(Diags, InFile, std::move(FS), HeaderSearchOpts,
-PPOpts, CodeGenOpts, C, CoverageInfo)),
+
steven_wu updated this revision to Diff 480990.
steven_wu marked 13 inline comments as done.
steven_wu added a comment.
Address review feedback.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139052/new/
https://reviews.llvm.org/D139052
Files:
cl
benlangmuir added inline comments.
Comment at: clang/lib/CodeGen/BackendUtil.cpp:194
: Diags(_Diags), HSOpts(HeaderSearchOpts), CodeGenOpts(CGOpts),
-TargetOpts(TOpts), LangOpts(LOpts), TheModule(M),
+TargetOpts(TOpts), LangOpts(LOpts), TheModule(M), VFS(VF
akyrtzi added inline comments.
Comment at: clang/include/clang/CodeGen/BackendUtil.h:14
#include "llvm/IR/ModuleSummaryIndex.h"
+#include "llvm/Support/VirtualFileSystem.h"
#include
Recommend to forward declare instead of including the header.
==
steven_wu created this revision.
steven_wu added reviewers: davidxl, tejohnson, xur, akyrtzi.
Herald added subscribers: Enna1, ormris, wenlei, ributzka, pengfei, hiraditya.
Herald added a project: All.
steven_wu requested review of this revision.
Herald added projects: clang, LLVM.
Herald added a s
13 matches
Mail list logo
