ariccio added a comment.
In http://reviews.llvm.org/D13893#343436, @angelgarcia wrote:
> The compiler complained about creating constant instances of classes
> without a user provided constructor (which is the case for the ASTMatchers).
>
> I gave up this change because it broke the build for a
The compiler complained about creating constant instances of classes
without a user provided constructor (which is the case for the ASTMatchers).
I gave up this change because it broke the build for a huge amount of
people and I didn't want that to happen again.
___
angelgarcia added a subscriber: angelgarcia.
angelgarcia added a comment.
The compiler complained about creating constant instances of classes
without a user provided constructor (which is the case for the ASTMatchers).
I gave up this change because it broke the build for a huge amount of
people
ariccio added a comment.
See original diff here: http://reviews.llvm.org/D13890
Repository:
rL LLVM
http://reviews.llvm.org/D13893
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ariccio added a subscriber: ariccio.
ariccio added a comment.
Whatever happened to this? What in `ASTMatchers` did it break? It seems like a
good change, and nobody followed up to fix it?
Repository:
rL LLVM
http://reviews.llvm.org/D13893
___
cf
This revision was automatically updated to reflect the committed changes.
Closed by commit rL250827: Roll-back r250822. (authored by angelgarcia).
Changed prior to commit:
http://reviews.llvm.org/D13893?vs=37875&id=37878#toc
Repository:
rL LLVM
http://reviews.llvm.org/D13893
Files:
cfe/tr
angelgarcia created this revision.
angelgarcia added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
It breaks the build for the ASTMatchers
http://reviews.llvm.org/D13893
Files:
include/clang/AST/ASTConsumer.h
include/clang/AST/CanonicalType.h
include/clang/AST/DeclFriend.h
