[PATCH] D138914: Make evaluation of nested requirement consistent with requires expr.

2022-12-21 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:2339 +Req->getConstraintExpr()->getSourceRange(), Satisfaction)) + TransConstraint = Result[0]; +assert(!Trap.hasErrorOccurred() && "Substitution failures must be handled " -

[PATCH] D138914: Make evaluation of nested requirement consistent with requires expr.

2022-12-21 Thread Utkarsh Saxena via Phabricator via cfe-commits
usaxena95 marked an inline comment as done. usaxena95 added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:2339 +Req->getConstraintExpr()->getSourceRange(), Satisfaction)) + TransConstraint = Result[0]; +assert(!Trap.hasErrorOccurred(

[PATCH] D138914: Make evaluation of nested requirement consistent with requires expr.

2022-12-21 Thread Richard Trieu via Phabricator via cfe-commits
rtrieu added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:2339 +Req->getConstraintExpr()->getSourceRange(), Satisfaction)) + TransConstraint = Result[0]; +assert(!Trap.hasErrorOccurred() && "Substitution failures must be handled " -

[PATCH] D138914: Make evaluation of nested requirement consistent with requires expr.

2022-12-19 Thread Utkarsh Saxena via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. usaxena95 marked an inline comment as done. Closed by commit rGb3ce87285186: Make evaluation of nested requirement consistent with requires expr. (authored by usaxena95

[PATCH] D138914: Make evaluation of nested requirement consistent with requires expr.

2022-12-19 Thread Utkarsh Saxena via Phabricator via cfe-commits
usaxena95 updated this revision to Diff 484013. usaxena95 added a comment. Herald added a subscriber: arphaman. Removed use of SubstitutionDiagnostic from NestedRequirement. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138914/new/ https://reviews.

[PATCH] D138914: Make evaluation of nested requirement consistent with requires expr.

2022-12-01 Thread Erich Keane via Phabricator via cfe-commits
erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. Happy now, thanks! Comment at: clang/include/clang/AST/ExprConcepts.h:428 + : Requirement(RK_Nested, +Constraint && Constraint->isInstantiati

[PATCH] D138914: Make evaluation of nested requirement consistent with requires expr.

2022-11-29 Thread Utkarsh Saxena via Phabricator via cfe-commits
usaxena95 updated this revision to Diff 478819. usaxena95 added a comment. Remove unintended whitespaces and new lines. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138914/new/ https://reviews.llvm.org/D138914 Files: clang/include/clang/AST/AST

[PATCH] D138914: Make evaluation of nested requirement consistent with requires expr.

2022-11-29 Thread Utkarsh Saxena via Phabricator via cfe-commits
usaxena95 updated this revision to Diff 478818. usaxena95 added a comment. Removed extraneous colons from diagnostic. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138914/new/ https://reviews.llvm.org/D138914 Files: clang/include/clang/AST/ASTCo

[PATCH] D138914: Make evaluation of nested requirement consistent with requires expr.

2022-11-29 Thread Utkarsh Saxena via Phabricator via cfe-commits
usaxena95 added inline comments. Comment at: clang/include/clang/AST/ExprConcepts.h:428 + : Requirement(RK_Nested, +Constraint && Constraint->isInstantiationDependent(), +Constraint && Constraint->containsUnexpandedParameterPack(), --

[PATCH] D138914: Make evaluation of nested requirement consistent with requires expr.

2022-11-29 Thread Utkarsh Saxena via Phabricator via cfe-commits
usaxena95 updated this revision to Diff 478814. usaxena95 marked 4 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138914/new/ https://reviews.llvm.org/D138914 Files: clang/in

[PATCH] D138914: Make evaluation of nested requirement consistent with requires expr.

2022-11-29 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added inline comments. Comment at: clang/include/clang/AST/ExprConcepts.h:428 + : Requirement(RK_Nested, +Constraint && Constraint->isInstantiationDependent(), +Constraint && Constraint->containsUnexpandedParameterPack(), -

[PATCH] D138914: Make evaluation of nested requirement consistent with requires expr.

2022-11-29 Thread Utkarsh Saxena via Phabricator via cfe-commits
usaxena95 updated this revision to Diff 478658. usaxena95 marked an inline comment as done. usaxena95 added a comment. Added tests. Fixed regressions in diagnositcs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138914/new/ https://reviews.llvm.org

[PATCH] D138914: Make evaluation of nested requirement consistent with requires expr.

2022-11-29 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added inline comments. Comment at: clang/include/clang/AST/ExprConcepts.h:428 + : Requirement(RK_Nested, +Constraint && Constraint->isInstantiationDependent(), +Constraint && Constraint->containsUnexpandedParameterPack(), -

[PATCH] D138914: Make evaluation of nested requirement consistent with requires expr.

2022-11-29 Thread Utkarsh Saxena via Phabricator via cfe-commits
usaxena95 created this revision. Herald added a project: All. usaxena95 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes: https://github.com/llvm/llvm-project/issues/45563 template concept True = true; template concept C1 =