[PATCH] D138901: [clang] Propely handle tests for open DRs in make_cxx_dr_status

h-vetinari added a comment. I'd also use newlines more liberally since the two-space indentation is pretty dense already. Comment at: clang/www/make_cxx_dr_status:190-191 + % (dr.issue, unresolved_status, dr.status) +if not avail.startswith('Sup') and not avail

[PATCH] D138901: [clang] Propely handle tests for open DRs in make_cxx_dr_status

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3d280b037530: [clang] Propely handle tests for open DRs in make_cxx_dr_status (authored by Endill, committed by erichkeane). Repository: rG LLVM G

[PATCH] D138901: [clang] Propely handle tests for open DRs in make_cxx_dr_status

erichkeane added a comment. Thanks @cor3ntin , I'll commit this then. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138901/new/ https://reviews.llvm.org/D138901 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D138901: [clang] Propely handle tests for open DRs in make_cxx_dr_status

cor3ntin added a comment. I don't see anything wrong with the python either. There are probably clever ways to deal with the successions of if statements but i don't think it would be worth it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138901/

[PATCH] D138901: [clang] Propely handle tests for open DRs in make_cxx_dr_status

Endill added a comment. Can I kindly ask you to commit this? I guess I can ask for commit access after this patch, and not bother you any further. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138901/new/ https://reviews.llvm.org/D138901

[PATCH] D138901: [clang] Propely handle tests for open DRs in make_cxx_dr_status

aaron.ballman accepted this revision as: aaron.ballman. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM though my Python skills are lacking, so additional eyeballs on that would be appreciated. Comment at: clang/www/make_cxx_dr_status:187-1

[PATCH] D138901: [clang] Propely handle tests for open DRs in make_cxx_dr_status

erichkeane added a comment. I like the change, thank you! I don't see anything to be concerned about, but my python is awful, so I'd like at least a 2nd set of eyes to take a look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138901/new/ https:/

[PATCH] D138901: [clang] Propely handle tests for open DRs in make_cxx_dr_status

Endill created this revision. Endill added reviewers: erichkeane, ychen, clang-language-wg. Herald added a project: All. Endill requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. A follow-up to D136133 . It wa