[PATCH] D138870: clang/AMDGPU: Remove flat-address-space from feature map

arsenm closed this revision. arsenm added a comment. 81849497b42e1a865af8aff65ab768e56a301c87 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138870/new/ https://reviews.llvm.org/D138870 __

[PATCH] D138870: clang/AMDGPU: Remove flat-address-space from feature map

Joe_Nash accepted this revision. Joe_Nash added a comment. This revision is now accepted and ready to land. In D138870#4020211 , @arsenm wrote: > In D138870#4020204 , @Joe_Nash > wrote: > >> The code looks fine,

[PATCH] D138870: clang/AMDGPU: Remove flat-address-space from feature map

arsenm updated this revision to Diff 486561. arsenm added a comment. Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138870/new/ https://reviews.llvm.org/D138870 Files: clang/lib/Basic/Targets/AMDGPU.cpp clang/test/CodeGenOpenCL/amdgpu-features.cl clang/test/OpenMP/amdgcn-at

[PATCH] D138870: clang/AMDGPU: Remove flat-address-space from feature map

arsenm added a comment. In D138870#4020204 , @Joe_Nash wrote: > The code looks fine, but as you say, the change visible in user code and > could break something. Do you want to handle that somehow? Maybe wait for > @b-sumner OpenMP assumes flat pointer

[PATCH] D138870: clang/AMDGPU: Remove flat-address-space from feature map

Joe_Nash added a comment. The code looks fine, but as you say, the change visible in user code and could break something. Do you want to handle that somehow? Maybe wait for @b-sumner Comment at: clang/test/OpenMP/metadirective_device_isa_codegen_amdgcn.cpp:17 #pragma omp meta

[PATCH] D138870: clang/AMDGPU: Remove flat-address-space from feature map

arsenm updated this revision to Diff 485650. arsenm added a comment. Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138870/new/ https://reviews.llvm.org/D138870 Files: clang/lib/Basic/Targets/AMDGPU.cpp clang/test/CodeGenOpenCL/amdgpu-features.cl clang/test/OpenMP/amdgcn-at

[PATCH] D138870: clang/AMDGPU: Remove flat-address-space from feature map

jdoerfert added a comment. The OpenMP part is fine. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138870/new/ https://reviews.llvm.org/D138870 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/list

[PATCH] D138870: clang/AMDGPU: Remove flat-address-space from feature map

arsenm created this revision. arsenm added reviewers: yaxunl, JonChesterfield, b-sumner, jdoerfert. Herald added subscribers: kosarev, kerbowa, tpr, dstuttard, jvesely, kzhuravl. Herald added a project: All. arsenm requested review of this revision. Herald added subscribers: sstefan1, wdng. This w