This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG07008a8df57f: CWG2635: Disallow constrained structured
bindings. (authored by erichkeane).
Herald added a project: clang.
Changed prior to commit:
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, but please add a release note when landing.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D138852/new/
https://reviews.llvm.org/D138852
___
erichkeane updated this revision to Diff 478351.
erichkeane marked 2 inline comments as done.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D138852/new/
https://reviews.llvm.org/D138852
Files:
clang/include/clang/Basic/DiagnosticSemaKinds.td
clang/lib/Sema/SemaDeclCXX.cpp
clang/test
aaron.ballman added a comment.
The changes look correct to me. The way to test the fix-it behavior is to model
after one of the tests in
https://github.com/llvm/llvm-project/tree/main/clang/test/FixIt (there is
`-fdiagnostics-parseable-fixits` and friends for this purpose).
erichkeane added a comment.
I would normally not really need a review here, but I did some stuff with the
fixit that I'm not sure about/not sure how to test, so I was hoping someone
could take a second look
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D138852/new/
https://reviews.llvm
erichkeane created this revision.
erichkeane added reviewers: clang-language-wg, aaron.ballman.
Herald added a project: All.
erichkeane requested review of this revision.
Herald added a reviewer: jdoerfert.
Herald added a subscriber: sstefan1.
CWG2635 prohibits adding a constraint to a structured
