shafik added inline comments.
Comment at: clang/test/SemaCXX/constant-expression-cxx2b.cpp:246
+
+constexpr double evaluate_static_constexpr() {
+ struct Constexpr{
Can we also add the test from the proposal as well for completeness sake:
```
constexpr char tes
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG5607fc002dd4: [Clang] Permit static constexpr variables in
constexpr functions (authored by cor3ntin).
Changed prior to commit:
https://reviews.ll
cor3ntin updated this revision to Diff 478321.
cor3ntin added a comment.
Add an evaluation test.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D138851/new/
https://reviews.llvm.org/D138851
Files:
clang/docs/ReleaseNotes.rst
clang/lib/AST/ExprCo
erichkeane added a comment.
Can you add some tests that do meaningful things with the static variable?
Particularly during constexpr evaluation time?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D138851/new/
https://reviews.llvm.org/D138851
cor3ntin created this revision.
Herald added a project: All.
cor3ntin requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
This implement the C++23 paper P2647R1 (adopted in Kona)
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org
