This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGf57f086714bc: [AArch64TargetParser] getArchFeatures ->
getArchFeature (authored by tmatheson).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE
pratlucas accepted this revision.
pratlucas added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D138753/new/
https://reviews.llvm.org/D138753
_
tmatheson updated this revision to Diff 478540.
tmatheson added a comment.
Reinstate unit test
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D138753/new/
https://reviews.llvm.org/D138753
Files:
clang/lib/Basic/Targets/AArch64.cpp
clang/lib/Driv
tmatheson added inline comments.
Comment at: llvm/unittests/Support/TargetParserTest.cpp:1686
-TEST(TargetParserTest, AArch64ArchFeatures) {
- std::vector Features;
pratlucas wrote:
> Can you keep a unit test covering the new version of the function?
The old v
pratlucas added inline comments.
Comment at: llvm/unittests/Support/TargetParserTest.cpp:1686
-TEST(TargetParserTest, AArch64ArchFeatures) {
- std::vector Features;
Can you keep a unit test covering the new version of the function?
Repository:
rG LLVM Gith
tmatheson created this revision.
tmatheson added reviewers: lenary, pratlucas, dmgreen, tschuett, DavidSpickett.
Herald added subscribers: hiraditya, kristof.beyls.
Herald added a project: All.
tmatheson requested review of this revision.
Herald added subscribers: llvm-commits, cfe-commits, MaskRay
