[PATCH] D138532: [SPARC][clang] Enable frame pointer optimization by default

This revision was automatically updated to reflect the committed changes. Closed by commit rG17d0a15478e9: [SPARC][clang] Enable frame pointer optimization by default (authored by koakuma, committed by brad). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D138532: [SPARC][clang] Enable frame pointer optimization by default

arsenm accepted this revision. arsenm added a comment. This revision is now accepted and ready to land. LGTM. I still find it strange that by default clang explicitly disables an optimization that's the default for unattributed functions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D138532: [SPARC][clang] Enable frame pointer optimization by default

koakuma added a comment. In D138532#3945422 , @MaskRay wrote: > I think we usually follow GCC instead of other targets. GCC enables it by default too, for example see https://godbolt.org/z/brPMKnM17 (That link also has comparison with clang with `-fomit

[PATCH] D138532: [SPARC][clang] Enable frame pointer optimization by default

MaskRay added a comment. > Enable frame pointer optimization by default to match it with other targets. I think we usually follow GCC instead of other targets. I am unfamiliar with sparc. Can you show an example where `-fomit-frame-pointer`/`-fno-omit-frame-pointer` demonstrate a codegen diffe

[PATCH] D138532: [SPARC][clang] Enable frame pointer optimization by default

koakuma created this revision. koakuma added reviewers: arsenm, MaskRay, brad, dcederman. Herald added subscribers: StephenFan, fedor.sergeev, jyknight. Herald added a project: All. koakuma requested review of this revision. Herald added subscribers: cfe-commits, wdng. Herald added a project: clang