[PATCH] D138520: [clangd] Make decision forest model optional

mgorny abandoned this revision. mgorny added a comment. Closing in favor of D139107 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138520/new/ https://reviews.llvm.org/D138520 ___ cfe-commits mailing list cf

[PATCH] D138520: [clangd] Make decision forest model optional

sammccall added inline comments. Comment at: clang-tools-extra/clangd/CodeComplete.h:129 +#if defined(CLANGD_DECISION_FOREST) +# define DEFAULT_RANKING_MODEL DecisionForest mgorny wrote: > sammccall wrote: > > this approach feels a bit heavy on the preprocesso

[PATCH] D138520: [clangd] Make decision forest model optional

mgorny added inline comments. Comment at: clang-tools-extra/clangd/CodeComplete.h:129 +#if defined(CLANGD_DECISION_FOREST) +# define DEFAULT_RANKING_MODEL DecisionForest sammccall wrote: > this approach feels a bit heavy on the preprocessor, especially for a h

[PATCH] D138520: [clangd] Make decision forest model optional

sammccall added a comment. Thanks for doing this! Comment at: clang-tools-extra/clangd/CMakeLists.txt:52 + list(APPEND COMPLETIONMODEL_SOURCES ${CMAKE_CURRENT_BINARY_DIR}/CompletionModel.cpp) + add_definitions(-DCLANGD_DECISION_FOREST=1) +endif() Rather than

[PATCH] D138520: [clangd] Make decision forest model optional

Arfrever added a comment. In `clang-tools-extra/clangd/unittests/CMakeLists.txt`, usage of `CompletionModel.cmake` probably also should be dependent on `CLANGD_DECISION_FOREST`. In `clang-tools-extra/clangd/CMakeLists.txt` and `clang-tools-extra/clangd/unittests/CMakeLists.txt`, calls to `tar

[PATCH] D138520: [clangd] Make decision forest model optional

thesamesam added a comment. Works on PPC. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138520/new/ https://reviews.llvm.org/D138520 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D138520: [clangd] Make decision forest model optional

mgorny added a comment. @thesamesam, could you test it on PPC32, please? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138520/new/ https://reviews.llvm.org/D138520 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D138520: [clangd] Make decision forest model optional

mgorny created this revision. mgorny added reviewers: thesamesam, sammccall, thakis, MaskRay. Herald added subscribers: StephenFan, kadircet, arphaman. Herald added a project: All. mgorny requested review of this revision. Herald added a subscriber: ilya-biryukov. Herald added a project: clang-tool